test_transitions_per_property says "interpolation of lengths" in non-length-testing functions

RESOLVED FIXED in mozilla11

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
While adding to test_transitions_per_property.html, I noticed that it's got "interpolation of lengths" as part of the subtest-description for some non-length properties.

In particular, the hits in test_zindex_transition() and test_pos_integer_or_auto_transition() are incorrect.  (those are testing interpolation of integer values, not lengths)

http://mxr.mozilla.org/mozilla-central/source/layout/style/test/test_transitions_per_property.html?force=1#852
http://mxr.mozilla.org/mozilla-central/source/layout/style/test/test_transitions_per_property.html?force=1#970
(Assignee)

Comment 1

6 years ago
Created attachment 571212 [details] [diff] [review]
trivial fix
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #571212 - Flags: review?(dbaron)
(Assignee)

Comment 2

6 years ago
These chunks are used for testing the properties "z-index" and "-moz-column-count", FWIW.
Comment on attachment 571212 [details] [diff] [review]
trivial fix

r=dbaron, though I'd actually have done "interpolation of z-index" and "interpolation of font-weight" since the functions are specific to those.  Feel free to do it that way.
Attachment #571212 - Flags: review?(dbaron) → review+
(Assignee)

Comment 4

6 years ago
(In reply to David Baron [:dbaron] from comment #3)
> Comment on attachment 571212 [details] [diff] [review] [diff] [details] [review]
> trivial fix
> 
> r=dbaron, though I'd actually have done "interpolation of z-index" and
> "interpolation of font-weight" since the functions are specific to those. 

I'm going to stick with "integers", if that's all right with you (sounds like it is), because:
 (1) while the first chunk (in "test_zindex_transition") is *currently* specific to z-index, it won't be for long.  I'm co-opting it to also test "flex-order" in the flex-order patch on bug 696253. (attachment 571221 [details] [diff] [review])

 (2) the second chunk ("test_pos_integer_or_auto_transition") is already used for multiple properties -- z-index and -moz-column-count, in particular.  (It's not used for font-weight -- that's only mentioned in the patch header-line because it's the function immediately *before* test_pos_integer_or_auto_transition)
(Assignee)

Comment 5

6 years ago
(meant to say -- thanks for the review!)
(Assignee)

Comment 6

6 years ago
Pushed:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/ad09520aac4b

(I pushed as DONTBUILD since this is only tweaking warning-strings within a mochitest, which can't affect test-behavior at all.)
OS: Linux → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla11

Comment 7

6 years ago
https://hg.mozilla.org/mozilla-central/rev/ad09520aac4b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.