699002 - Use a xul:checkbox for "Only user styles" option

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

When xul:checkboxes are used in xhtml docs they are rendered incorrectly

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch used to reproduce the problem

To reproduce:
1. Go to the web console (Firefox -> Web Developer -> Web Console)
2. Enter "inspectstyle(document.body)"

The style inspector will appear with a xul:checkbox from the land of ugly (see attached image).

Clicking the checkbox, which looks more like a text field, does nothing.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Screenshot of xul:checkbox from the land of ugly

Comment 3

[Boris Zbarsky [:bzbarsky]]

Isn't that checkbox there this one:

+        <input class="onlyuserstyles" save="${onlyUserStylesCheckbox}"
+               type="checkbox" onchange="${onlyUserStylesChanged}" checked=""/>

?  If so, that's an html:input, not a xul:checkbox, unless I'm seriously missing something....

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Patch used to reproduce the problem

(In reply to Boris Zbarsky (:bz) from comment #3)
> Isn't that checkbox there this one:
> 
> +        <input class="onlyuserstyles" save="${onlyUserStylesCheckbox}"
> +               type="checkbox" onchange="${onlyUserStylesChanged}"
> checked=""/>
> 
> ?  If so, that's an html:input, not a xul:checkbox, unless I'm seriously
> missing something....

lol ... I attached the wrong patch. It is reproducible with this one.

Comment 5

[Boris Zbarsky [:bzbarsky]]

That last patch doesn't apply to m-c.  On m-c there is no <xul:hbox class="header" flex="1"> or <xul:textarea>.  Instead there is a <div class="filters"> and an HTML <input>.

Comment 6

[Dão Gottwald [:dao]]

Attachment: WIP patch

Michael's patch was missing align="center".

Comment 7

[Dão Gottwald [:dao]]

Attachment: patch

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 572441 [details] [diff] [review]
patch

 
-.onlyuserstyles,
-.userStylesLabel {
+.onlyuserstyles {

not a fan of this capitalization (would prefer onlyUserStyles).

but here we are.

Comment 9

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/900478e42d35

Comment 10

[Boris Zbarsky [:bzbarsky]]

So is there still a core rendering issue I should be worried about here?

Comment 11

[Dão Gottwald [:dao]]

(In reply to Boris Zbarsky (:bz) from comment #10)
> So is there still a core rendering issue I should be worried about here?

nope

Comment 12

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/900478e42d35