Closed Bug 699002 Opened 8 years ago Closed 8 years ago

Use a xul:checkbox for "Only user styles" option

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 10

People

(Reporter: miker, Assigned: dao)

References

Details

(Whiteboard: [styleinspector])

Attachments

(1 file, 4 obsolete files)

When xul:checkboxes are used in xhtml docs they are rendered incorrectly
To reproduce:
1. Go to the web console (Firefox -> Web Developer -> Web Console)
2. Enter "inspectstyle(document.body)"

The style inspector will appear with a xul:checkbox from the land of ugly (see attached image).

Clicking the checkbox, which looks more like a text field, does nothing.
Isn't that checkbox there this one:

+        <input class="onlyuserstyles" save="${onlyUserStylesCheckbox}"
+               type="checkbox" onchange="${onlyUserStylesChanged}" checked=""/>

?  If so, that's an html:input, not a xul:checkbox, unless I'm seriously missing something....
(In reply to Boris Zbarsky (:bz) from comment #3)
> Isn't that checkbox there this one:
> 
> +        <input class="onlyuserstyles" save="${onlyUserStylesCheckbox}"
> +               type="checkbox" onchange="${onlyUserStylesChanged}"
> checked=""/>
> 
> ?  If so, that's an html:input, not a xul:checkbox, unless I'm seriously
> missing something....

lol ... I attached the wrong patch. It is reproducible with this one.
Attachment #571280 - Attachment is obsolete: true
That last patch doesn't apply to m-c.  On m-c there is no <xul:hbox class="header" flex="1"> or <xul:textarea>.  Instead there is a <div class="filters"> and an HTML <input>.
Attached patch WIP patch (obsolete) — Splinter Review
Michael's patch was missing align="center".
Assignee: nobody → dao
Attachment #571285 - Attachment is obsolete: true
Attachment #571322 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Component: XUL → Developer Tools
Product: Core → Firefox
QA Contact: xptoolkit.widgets → developer.tools
Summary: xul:checkbox rendered incorrectly when used in xhtml docs → Use a xul:checkbox for "Only user styles" option
Whiteboard: [styleinspector]
Attached patch patchSplinter Review
Attachment #572438 - Attachment is obsolete: true
Attachment #572441 - Flags: review?(mihai.sucan)
Comment on attachment 572441 [details] [diff] [review]
patch

 
-.onlyuserstyles,
-.userStylesLabel {
+.onlyuserstyles {

not a fan of this capitalization (would prefer onlyUserStyles).

but here we are.
Attachment #572441 - Flags: review+
Attachment #572441 - Flags: review?(mihai.sucan)
https://hg.mozilla.org/integration/fx-team/rev/900478e42d35
Target Milestone: --- → Firefox 10
So is there still a core rendering issue I should be worried about here?
(In reply to Boris Zbarsky (:bz) from comment #10)
> So is there still a core rendering issue I should be worried about here?

nope
https://hg.mozilla.org/mozilla-central/rev/900478e42d35
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.