Last Comment Bug 699002 - Use a xul:checkbox for "Only user styles" option
: Use a xul:checkbox for "Only user styles" option
Status: RESOLVED FIXED
[styleinspector]
:
Product: Firefox
Classification: Client Software
Component: Developer Tools (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 10
Assigned To: Dão Gottwald [:dao]
:
Mentors:
Depends on: 672748
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-02 02:26 PDT by Michael Ratcliffe [:miker] [:mratcliffe]
Modified: 2011-11-07 14:54 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch used to reproduce the problem (59.42 KB, patch)
2011-11-02 02:33 PDT, Michael Ratcliffe [:miker] [:mratcliffe]
no flags Details | Diff | Review
Screenshot of xul:checkbox from the land of ugly (33.40 KB, image/png)
2011-11-02 02:46 PDT, Michael Ratcliffe [:miker] [:mratcliffe]
no flags Details
Patch used to reproduce the problem (1.49 KB, patch)
2011-11-02 06:44 PDT, Michael Ratcliffe [:miker] [:mratcliffe]
no flags Details | Diff | Review
WIP patch (4.04 KB, patch)
2011-11-07 05:17 PST, Dão Gottwald [:dao]
no flags Details | Diff | Review
patch (4.04 KB, patch)
2011-11-07 05:27 PST, Dão Gottwald [:dao]
rcampbell: review+
Details | Diff | Review

Description Michael Ratcliffe [:miker] [:mratcliffe] 2011-11-02 02:26:19 PDT
When xul:checkboxes are used in xhtml docs they are rendered incorrectly
Comment 1 Michael Ratcliffe [:miker] [:mratcliffe] 2011-11-02 02:33:27 PDT
Created attachment 571280 [details] [diff] [review]
Patch used to reproduce the problem

To reproduce:
1. Go to the web console (Firefox -> Web Developer -> Web Console)
2. Enter "inspectstyle(document.body)"

The style inspector will appear with a xul:checkbox from the land of ugly (see attached image).

Clicking the checkbox, which looks more like a text field, does nothing.
Comment 2 Michael Ratcliffe [:miker] [:mratcliffe] 2011-11-02 02:46:26 PDT
Created attachment 571285 [details]
Screenshot of xul:checkbox from the land of ugly
Comment 3 Boris Zbarsky [:bz] 2011-11-02 06:31:43 PDT
Isn't that checkbox there this one:

+        <input class="onlyuserstyles" save="${onlyUserStylesCheckbox}"
+               type="checkbox" onchange="${onlyUserStylesChanged}" checked=""/>

?  If so, that's an html:input, not a xul:checkbox, unless I'm seriously missing something....
Comment 4 Michael Ratcliffe [:miker] [:mratcliffe] 2011-11-02 06:44:00 PDT
Created attachment 571322 [details] [diff] [review]
Patch used to reproduce the problem

(In reply to Boris Zbarsky (:bz) from comment #3)
> Isn't that checkbox there this one:
> 
> +        <input class="onlyuserstyles" save="${onlyUserStylesCheckbox}"
> +               type="checkbox" onchange="${onlyUserStylesChanged}"
> checked=""/>
> 
> ?  If so, that's an html:input, not a xul:checkbox, unless I'm seriously
> missing something....

lol ... I attached the wrong patch. It is reproducible with this one.
Comment 5 Boris Zbarsky [:bz] 2011-11-03 11:06:44 PDT
That last patch doesn't apply to m-c.  On m-c there is no <xul:hbox class="header" flex="1"> or <xul:textarea>.  Instead there is a <div class="filters"> and an HTML <input>.
Comment 6 Dão Gottwald [:dao] 2011-11-07 05:17:42 PST
Created attachment 572438 [details] [diff] [review]
WIP patch

Michael's patch was missing align="center".
Comment 7 Dão Gottwald [:dao] 2011-11-07 05:27:58 PST
Created attachment 572441 [details] [diff] [review]
patch
Comment 8 Rob Campbell [:rc] (:robcee) 2011-11-07 07:19:14 PST
Comment on attachment 572441 [details] [diff] [review]
patch

 
-.onlyuserstyles,
-.userStylesLabel {
+.onlyuserstyles {

not a fan of this capitalization (would prefer onlyUserStyles).

but here we are.
Comment 9 Dão Gottwald [:dao] 2011-11-07 07:26:18 PST
https://hg.mozilla.org/integration/fx-team/rev/900478e42d35
Comment 10 Boris Zbarsky [:bz] 2011-11-07 08:24:44 PST
So is there still a core rendering issue I should be worried about here?
Comment 11 Dão Gottwald [:dao] 2011-11-07 08:54:27 PST
(In reply to Boris Zbarsky (:bz) from comment #10)
> So is there still a core rendering issue I should be worried about here?

nope
Comment 12 Rob Campbell [:rc] (:robcee) 2011-11-07 14:54:59 PST
https://hg.mozilla.org/mozilla-central/rev/900478e42d35

Note You need to log in before you can comment on or make changes to this bug.