Last Comment Bug 699009 - Remove MOZ_USE_NATIVE_UCONV
: Remove MOZ_USE_NATIVE_UCONV
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: Internationalization (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla10
Assigned To: Makoto Kato [:m_kato]
:
Mentors:
http://mxr.mozilla.org/mozilla-centra...
Depends on:
Blocks: 644801
  Show dependency treegraph
 
Reported: 2011-11-02 03:12 PDT by Makoto Kato [:m_kato]
Modified: 2011-11-04 03:08 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (1.50 KB, patch)
2011-11-02 04:35 PDT, Makoto Kato [:m_kato]
smontagu: review+
Details | Diff | Review

Description Makoto Kato [:m_kato] 2011-11-02 03:12:33 PDT
By bug 644801, MOZ_USE_NATIVE_UCONV is unnecessary.  But there is still this define.  We should remove it.
Comment 1 Makoto Kato [:m_kato] 2011-11-02 04:35:50 PDT
Created attachment 571307 [details] [diff] [review]
fix
Comment 3 Ed Morley [:emorley] 2011-11-04 01:47:28 PDT
Should components/ucnative.xpt go into removed files?
Comment 4 Makoto Kato [:m_kato] 2011-11-04 01:52:27 PDT
(In reply to Ed Morley [:edmorley] from comment #3)
> Should components/ucnative.xpt go into removed files?

Native uconv was used by Minimo (for Windows mobile) and this build option wasn't used on Firefox/Thunderbird/SeaMonkey/Mozilla Suite.  I don't think we should add it to removed file.
Comment 5 Ed Morley [:emorley] 2011-11-04 03:08:09 PDT
Ah, true :-)

https://hg.mozilla.org/mozilla-central/rev/b75b24b8b633

Note You need to log in before you can comment on or make changes to this bug.