699147 - Simplify length list parsing

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert Longson [:longsonr]]

Attachment: patch

Avoid changing from utf16 to utf8 and back again.

Comment 1

[Jonathan Watt [:jwatt]]

Comment on attachment 571374 [details] [diff] [review]
patch

Change this line:

>+    temp.AppendItem(length);

to:

>-    if (!temp.AppendItem(length)) {
>-      return NS_ERROR_OUT_OF_MEMORY;
>-    }

since AppendItem is allocation fallible, and r=jwatt.

Comment 2

[Robert Longson [:longsonr]]

I'll change the SVGNumberList parsing to return NS_ERROR_OUT_OF_MEMORY for appendItem then.

Comment 3

[Jonathan Watt [:jwatt]]

perfect, thanks!

Comment 4

[Robert Longson [:longsonr]]

pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/c4c529e9a2d3

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/c4c529e9a2d3