Simplify length list parsing

RESOLVED FIXED in mozilla11

Status

()

Core
SVG
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Robert Longson, Assigned: Robert Longson)

Tracking

Trunk
mozilla11
x86_64
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 571374 [details] [diff] [review]
patch

Avoid changing from utf16 to utf8 and back again.
(Assignee)

Updated

6 years ago
Attachment #571374 - Attachment is patch: true
Attachment #571374 - Flags: review?(jwatt)
Comment on attachment 571374 [details] [diff] [review]
patch

Change this line:

>+    temp.AppendItem(length);

to:

>-    if (!temp.AppendItem(length)) {
>-      return NS_ERROR_OUT_OF_MEMORY;
>-    }

since AppendItem is allocation fallible, and r=jwatt.
Attachment #571374 - Flags: review?(jwatt) → review+
(Assignee)

Comment 2

6 years ago
I'll change the SVGNumberList parsing to return NS_ERROR_OUT_OF_MEMORY for appendItem then.
perfect, thanks!
(Assignee)

Updated

6 years ago
Assignee: nobody → longsonr
(Assignee)

Comment 4

6 years ago
pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/c4c529e9a2d3
Flags: in-testsuite-
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/c4c529e9a2d3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.