Closed Bug 699147 Opened 12 years ago Closed 12 years ago

Simplify length list parsing

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla11

People

(Reporter: longsonr, Assigned: longsonr)

Details

Attachments

(1 file)

patch
2.23 KB, patch
jwatt
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
Avoid changing from utf16 to utf8 and back again.
Attachment #571374 - Attachment is patch: true
Attachment #571374 - Flags: review?(jwatt)
Comment on attachment 571374 [details] [diff] [review]
patch

Change this line:

>+    temp.AppendItem(length);

to:

>-    if (!temp.AppendItem(length)) {
>-      return NS_ERROR_OUT_OF_MEMORY;
>-    }

since AppendItem is allocation fallible, and r=jwatt.
Attachment #571374 - Flags: review?(jwatt) → review+
I'll change the SVGNumberList parsing to return NS_ERROR_OUT_OF_MEMORY for appendItem then.
perfect, thanks!
Assignee: nobody → longsonr
pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/c4c529e9a2d3
Flags: in-testsuite-
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/c4c529e9a2d3
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.