699155 - Tabs list ordering

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Wesley Johnston (:wesj)]

Playing with context menus, I've opened links in background tabs and noticed that they often appear in the tabs list "out of order". I think maybe the simplest things is just to ensure that tabs show up in the order they were opened.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch gets the Tabs list in order and uses it for populating the list. HashMap doesnt always preserve the order.
Also, the values are copied into list's adapter. Having a reference can cause problems. Hence the values have to be copied.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 571567 [details] [diff] [review]
Patch

I don't see any users of the HashMap getTabs call. Maybe we should just make getTabs return the ArrayList?

Comment 3

[Sriram Ramasubramanian [:sriram]]

I too looked at the same. I thought of cleaning up Tabs along with changes that Lucas had proposed -- making it a normal class and not a singleton.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/projects/birch/rev/388c49fba3fd

Comment 5

[Aaron Train [:aaronmt]]

20111103121050
http://hg.mozilla.org/projects/birch/rev/d479ad392377
Samsung Nexus S (Android 2.3.6)

Comment 6

[Wesley Johnston (:wesj)]

These patches were backed while investigating Talos failures.  Now that tests are green again, we will need to reland.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

backout was backed out https://hg.mozilla.org/projects/birch/rev/6f925b45a547

Comment 8

[Aaron Train [:aaronmt]]

20111114041052
http://hg.mozilla.org/projects/birch/rev/859ecdfe0168
Samsung Galaxy SII (Android 2.3.4)

Comment 9

[Camelia Urian]

Test case created in BFT - Tabbed Browsing:
https://litmus.mozilla.org/show_test.cgi?id=40430