Playing with context menus, I've opened links in background tabs and noticed that they often appear in the tabs list "out of order". I think maybe the simplest things is just to ensure that tabs show up in the order they were opened.
Created attachment 571567 [details] [diff] [review]
This patch gets the Tabs list in order and uses it for populating the list. HashMap doesnt always preserve the order.
Also, the values are copied into list's adapter. Having a reference can cause problems. Hence the values have to be copied.
Comment on attachment 571567 [details] [diff] [review]
I don't see any users of the HashMap getTabs call. Maybe we should just make getTabs return the ArrayList?
I too looked at the same. I thought of cleaning up Tabs along with changes that Lucas had proposed -- making it a normal class and not a singleton.
Samsung Nexus S (Android 2.3.6)
These patches were backed while investigating Talos failures. Now that tests are green again, we will need to reland.
backout was backed out https://hg.mozilla.org/projects/birch/rev/6f925b45a547
Samsung Galaxy SII (Android 2.3.4)
Test case created in BFT - Tabbed Browsing: