Status

()

Firefox for Android
General
P2
normal
VERIFIED FIXED
6 years ago
11 months ago

People

(Reporter: wesj, Assigned: sriram)

Tracking

unspecified
Points:
---
Bug Flags:
in-testsuite +
in-litmus +

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Playing with context menus, I've opened links in background tabs and noticed that they often appear in the tabs list "out of order". I think maybe the simplest things is just to ensure that tabs show up in the order they were opened.
(Assignee)

Updated

6 years ago
Assignee: nobody → sriram
(Assignee)

Comment 1

6 years ago
Created attachment 571567 [details] [diff] [review]
Patch

This patch gets the Tabs list in order and uses it for populating the list. HashMap doesnt always preserve the order.
Also, the values are copied into list's adapter. Having a reference can cause problems. Hence the values have to be copied.
Attachment #571567 - Flags: review?(mark.finkle)
Comment on attachment 571567 [details] [diff] [review]
Patch

I don't see any users of the HashMap getTabs call. Maybe we should just make getTabs return the ArrayList?
Attachment #571567 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 3

6 years ago
I too looked at the same. I thought of cleaning up Tabs along with changes that Lucas had proposed -- making it a normal class and not a singleton.
Priority: -- → P2
https://hg.mozilla.org/projects/birch/rev/388c49fba3fd
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
20111103121050
http://hg.mozilla.org/projects/birch/rev/d479ad392377
Samsung Nexus S (Android 2.3.6)
Status: RESOLVED → VERIFIED
(Reporter)

Comment 6

6 years ago
These patches were backed while investigating Talos failures.  Now that tests are green again, we will need to reland.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
backout was backed out https://hg.mozilla.org/projects/birch/rev/6f925b45a547
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
20111114041052
http://hg.mozilla.org/projects/birch/rev/859ecdfe0168
Samsung Galaxy SII (Android 2.3.4)
Status: RESOLVED → VERIFIED
Flags: in-testsuite?
Flags: in-litmus?(fennec)
Whiteboard: [QA+]

Comment 9

6 years ago
Test case created in BFT - Tabbed Browsing:
https://litmus.mozilla.org/show_test.cgi?id=40430
Flags: in-testsuite?
Flags: in-testsuite+
Flags: in-litmus?(fennec)
Flags: in-litmus+
Whiteboard: [QA+]
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.