Last Comment Bug 699155 - Tabs list ordering
: Tabs list ordering
Product: Firefox for Android
Classification: Client Software
Component: General (show other bugs)
: unspecified
: All All
P2 normal (vote)
: ---
Assigned To: Sriram Ramasubramanian [:sriram]
: Sebastian Kaspari (:sebastian)
Depends on:
  Show dependency treegraph
Reported: 2011-11-02 11:03 PDT by Wesley Johnston (:wesj)
Modified: 2016-07-29 14:20 PDT (History)
4 users (show)
camelia.urian: in‑testsuite+
camelia.urian: in‑litmus+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

Patch (2.96 KB, patch)
2011-11-02 23:44 PDT, Sriram Ramasubramanian [:sriram]
mark.finkle: review+
Details | Diff | Splinter Review

Description User image Wesley Johnston (:wesj) 2011-11-02 11:03:37 PDT
Playing with context menus, I've opened links in background tabs and noticed that they often appear in the tabs list "out of order". I think maybe the simplest things is just to ensure that tabs show up in the order they were opened.
Comment 1 User image Sriram Ramasubramanian [:sriram] 2011-11-02 23:44:29 PDT
Created attachment 571567 [details] [diff] [review]

This patch gets the Tabs list in order and uses it for populating the list. HashMap doesnt always preserve the order.
Also, the values are copied into list's adapter. Having a reference can cause problems. Hence the values have to be copied.
Comment 2 User image Mark Finkle (:mfinkle) (use needinfo?) 2011-11-03 05:38:08 PDT
Comment on attachment 571567 [details] [diff] [review]

I don't see any users of the HashMap getTabs call. Maybe we should just make getTabs return the ArrayList?
Comment 3 User image Sriram Ramasubramanian [:sriram] 2011-11-03 08:57:24 PDT
I too looked at the same. I thought of cleaning up Tabs along with changes that Lucas had proposed -- making it a normal class and not a singleton.
Comment 4 User image Mark Finkle (:mfinkle) (use needinfo?) 2011-11-03 12:14:19 PDT
Comment 5 User image Aaron Train [:aaronmt] 2011-11-03 15:07:21 PDT
Samsung Nexus S (Android 2.3.6)
Comment 6 User image Wesley Johnston (:wesj) 2011-11-10 10:22:28 PST
These patches were backed while investigating Talos failures.  Now that tests are green again, we will need to reland.
Comment 7 User image Brad Lassey [:blassey] (use needinfo?) 2011-11-11 09:01:27 PST
backout was backed out
Comment 8 User image Aaron Train [:aaronmt] 2011-11-14 06:50:30 PST
Samsung Galaxy SII (Android 2.3.4)
Comment 9 User image Camelia Urian 2011-11-29 06:07:40 PST
Test case created in BFT - Tabbed Browsing:

Note You need to log in before you can comment on or make changes to this bug.