699170 - Tons of JS_* redefined warnings on mingw

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jacek Caban]

Attachment: fix v1.0

Bug 694499 made jscpucfg.h include unconditional in jstypes.h. jscpucfg.h contains some defines that are hardcoded for MSVC, but are in js-confdefs.h or js-config.h on other platforms, including mingw. That causes warnings like this:

home/jacek/mozilla-build/mozilla-central/js/src/jscpucfg.h:66:0: warning: "JS_BYTES_PER_DOUBLE" redefined [enabled by default]
././js-confdefs.h:45:0: note: this is the location of the previous definition
/home/jacek/mozilla-build/mozilla-central/js/src/jscpucfg.h:67:0: warning: "JS_BYTES_PER_WORD" redefined [enabled by default]
./js-config.h:93:0: note: this is the location of the previous definition
/home/jacek/mozilla-build/mozilla-central/js/src/jscpucfg.h:69:0: warning: "JS_ALIGN_OF_POINTER" redefined [enabled by default]
././js-confdefs.h:43:0: note: this is the location of the previous definition

The attached patch changes hardcoded values to not contain L prefix (so they become ints instead of longs), which matches what js-confdefs.h and js-config.h do, so there is no warning if defined values match.

Comment 1

[Jacek Caban]

Thanks for the review, pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/26130bafc0ee

Comment 2

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/26130bafc0ee