Tons of JS_* redefined warnings on mingw

RESOLVED FIXED in mozilla10

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla10
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 571399 [details] [diff] [review]
fix v1.0

Bug 694499 made jscpucfg.h include unconditional in jstypes.h. jscpucfg.h contains some defines that are hardcoded for MSVC, but are in js-confdefs.h or js-config.h on other platforms, including mingw. That causes warnings like this:

home/jacek/mozilla-build/mozilla-central/js/src/jscpucfg.h:66:0: warning: "JS_BYTES_PER_DOUBLE" redefined [enabled by default]
././js-confdefs.h:45:0: note: this is the location of the previous definition
/home/jacek/mozilla-build/mozilla-central/js/src/jscpucfg.h:67:0: warning: "JS_BYTES_PER_WORD" redefined [enabled by default]
./js-config.h:93:0: note: this is the location of the previous definition
/home/jacek/mozilla-build/mozilla-central/js/src/jscpucfg.h:69:0: warning: "JS_ALIGN_OF_POINTER" redefined [enabled by default]
././js-confdefs.h:43:0: note: this is the location of the previous definition

The attached patch changes hardcoded values to not contain L prefix (so they become ints instead of longs), which matches what js-confdefs.h and js-config.h do, so there is no warning if defined values match.
Attachment #571399 - Flags: review?(ted.mielczarek)
Attachment #571399 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 1

6 years ago
Thanks for the review, pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/26130bafc0ee
Whiteboard: [inbound]

Comment 2

6 years ago
https://hg.mozilla.org/mozilla-central/rev/26130bafc0ee
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.