Last Comment Bug 699170 - Tons of JS_* redefined warnings on mingw
: Tons of JS_* redefined warnings on mingw
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla10
Assigned To: Jacek Caban
:
Mentors:
Depends on:
Blocks: 694499
  Show dependency treegraph
 
Reported: 2011-11-02 11:47 PDT by Jacek Caban
Modified: 2011-11-08 07:07 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix v1.0 (1.33 KB, patch)
2011-11-02 11:47 PDT, Jacek Caban
ted: review+
Details | Diff | Review

Description Jacek Caban 2011-11-02 11:47:58 PDT
Created attachment 571399 [details] [diff] [review]
fix v1.0

Bug 694499 made jscpucfg.h include unconditional in jstypes.h. jscpucfg.h contains some defines that are hardcoded for MSVC, but are in js-confdefs.h or js-config.h on other platforms, including mingw. That causes warnings like this:

home/jacek/mozilla-build/mozilla-central/js/src/jscpucfg.h:66:0: warning: "JS_BYTES_PER_DOUBLE" redefined [enabled by default]
././js-confdefs.h:45:0: note: this is the location of the previous definition
/home/jacek/mozilla-build/mozilla-central/js/src/jscpucfg.h:67:0: warning: "JS_BYTES_PER_WORD" redefined [enabled by default]
./js-config.h:93:0: note: this is the location of the previous definition
/home/jacek/mozilla-build/mozilla-central/js/src/jscpucfg.h:69:0: warning: "JS_ALIGN_OF_POINTER" redefined [enabled by default]
././js-confdefs.h:43:0: note: this is the location of the previous definition

The attached patch changes hardcoded values to not contain L prefix (so they become ints instead of longs), which matches what js-confdefs.h and js-config.h do, so there is no warning if defined values match.
Comment 1 Jacek Caban 2011-11-08 01:38:41 PST
Thanks for the review, pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/26130bafc0ee
Comment 2 Ed Morley [:emorley] 2011-11-08 07:07:00 PST
https://hg.mozilla.org/mozilla-central/rev/26130bafc0ee

Note You need to log in before you can comment on or make changes to this bug.