699204 - Use the QSB suggestion provider for suggested or filtered results on landscape awesome bar input

Status: RESOLVED WORKSFORME

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Aaron Train [:aaronmt]]

Attachment: Stock QSB

Currently when one enters a URL in landscape, the virtual keyboard takes up the entire screen. Despite the filtering of input going on behind the virtual keyboard, the quick search box provider should provide these results available right on the screen for tap.

--
20111102040257
http://hg.mozilla.org/projects/birch/rev/2b9de9749c1e

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Nightly (11/02)

Comment 2

[Sriram Ramasubramanian [:sriram]]

I don't quite understand the bug here. I searched for QSB and got this: http://developer.android.com/resources/articles/qsb.html

Comment 3

[Aaron Train [:aaronmt]]

See the first screenshot? It's the row of available suggestions that are above the keyboard and below the edit box. I think you can provide a 'provider' that will reference bookmarks for example, and the dictionary provider. This would help shorten the amount of typing required in landscape, if the user can just tap the suggestion from their input.

Comment 4

[bug.zilla]

Have a look at how the YouTube app shows hits when in landscape mode.
Works pretty well.

Comment 5

[bug.zilla]

With the latest version of Firefox and using the default Android keyboard, there is just about enough room to see the results. However using the HTC keyboard (HTC_IME) the keyboard takes up too much of the screen.

Comment 6

[bug.zilla]

Hi, is this still being looked into?

Comment 7

[Wesley Johnston (:wesj)]

No one has had time to look at it yet, but the bug hasn't been closed. Maybe when someone has some free cycles.

Comment 8

[Aaron Train [:aaronmt]]

Now that I re-read this, I'm not sure if my Android-terminology/references in the summary are right here or if this is still desirable. In landscape mode, we get AwesomeBar results, so would we want stock (locale) dictionary results above the keyboard too?

Comment 9

[bug.zilla]

Hi, sorry, this is no longer a bug for me using the stock keyboard.
There's not much room to see results using the HTC_IME keyboard but that's got nothing to do with Firefox.