699230 - Expose GetObjectCompartment in JSAPI

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Seemed like an easy start for bug 692267. Not sure if this should be a public or friend API.

Comment 1

[Jeff Walden [:Waldo]]

Comment on attachment 571458 [details] [diff] [review]
Patch v1

Review of attachment 571458 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think we understand yet what the APIs should look like for working with compartments.  We have the enter/leave-compartment APIs, but even various Gecko hackers find them confusing and don't understand when and how they should be used.  I know Luke has plans to make various changes to them, which might alleviate the need for these APIs, or at the very least change the way they look.  I think this should continue to be a friend API for now, because we don't know what we're doing well enough to expose it publicly.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Additionally, we don't know how important it is for this to be inlined. I tried to compare Talos results, but somehow the builds failed and I never got back to it.