The default bug view has changed. See this FAQ.

Ctrl+F4 should not close App Tabs

RESOLVED FIXED in Firefox 10

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

({ux-error-prevention})

unspecified
Firefox 10
All
Windows XP
ux-error-prevention
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 1 obsolete attachment)

When closing many tabs, it is easy to hold down ctrl+f4. The tabs close fast, but App Tabs (which are promoted to a higher-class, longer-living tab) are also closed by ctrl+f4.

To prevent user errors, we shouldn't allow ctrl+f4 to close app tabs.
Created attachment 571484 [details] [diff] [review]
Patch for bug 699240

I ran the mochitest-browser-chrome tests locally with no failures.
Assignee: nobody → jwein
Status: NEW → ASSIGNED
Attachment #571484 - Flags: review?(gavin.sharp)
Attachment #571484 - Attachment description: Patch for bug 669240 → Patch for bug 699240
Attachment #571484 - Attachment filename: 669240.patch → 699240.patch
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=00930bf79d18
Created attachment 571500 [details] [diff] [review]
Patch for bug 699240

Removed the check for ctrlPageUpPageDown since it is unnecessary based on this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=628918#c1

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=a41e006b29e0
Attachment #571484 - Attachment is obsolete: true
Attachment #571484 - Flags: review?(gavin.sharp)
Attachment #571500 - Flags: review?(gavin.sharp)
Attachment #571500 - Flags: review?(gavin.sharp) → review+
Fixed in fx-team: https://hg.mozilla.org/integration/fx-team/rev/73e8ca9230d6
Whiteboard: [fixed-in-fx-team]
backed-out in: https://hg.mozilla.org/mozilla-central/rev/2be7246491d5

wrong commit message.
Whiteboard: [fixed-in-fx-team] → [backed-out]
Repushed with fixed commit message: https://hg.mozilla.org/integration/fx-team/rev/ae7e205b7dc4
Whiteboard: [backed-out] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/ae7e205b7dc4
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
You need to log in before you can comment on or make changes to this bug.