Closed
Bug 699240
Opened 13 years ago
Closed 13 years ago
Ctrl+F4 should not close App Tabs
Categories
(Firefox :: Tabbed Browser, defect)
Tracking
()
RESOLVED
FIXED
Firefox 10
People
(Reporter: jaws, Assigned: jaws)
Details
(Keywords: ux-error-prevention, Whiteboard: [fixed-in-fx-team])
Attachments
(1 file, 1 obsolete file)
|
963 bytes,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
When closing many tabs, it is easy to hold down ctrl+f4. The tabs close fast, but App Tabs (which are promoted to a higher-class, longer-living tab) are also closed by ctrl+f4. To prevent user errors, we shouldn't allow ctrl+f4 to close app tabs.
|
Assignee | |
Comment 1•13 years ago
|
||
I ran the mochitest-browser-chrome tests locally with no failures.
|
|
Assignee | |
Updated•13 years ago
|
Attachment #571484 -
Attachment description: Patch for bug 669240 → Patch for bug 699240
Attachment #571484 -
Attachment filename: 669240.patch → 699240.patch
|
|
Assignee | |
Comment 2•13 years ago
|
||
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=00930bf79d18
|
|
Assignee | |
Comment 3•13 years ago
|
||
Removed the check for ctrlPageUpPageDown since it is unnecessary based on this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=628918#c1 Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=a41e006b29e0
Attachment #571484 -
Attachment is obsolete: true
Attachment #571484 -
Flags: review?(gavin.sharp)
Attachment #571500 -
Flags: review?(gavin.sharp)
|
||
Updated•13 years ago
|
Attachment #571500 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Fixed in fx-team: https://hg.mozilla.org/integration/fx-team/rev/73e8ca9230d6
Whiteboard: [fixed-in-fx-team]
|
||
Comment 5•13 years ago
|
||
backed-out in: https://hg.mozilla.org/mozilla-central/rev/2be7246491d5 wrong commit message.
|
|
||
Updated•13 years ago
|
Whiteboard: [fixed-in-fx-team] → [backed-out]
|
|
Assignee | |
Comment 6•13 years ago
|
||
Repushed with fixed commit message: https://hg.mozilla.org/integration/fx-team/rev/ae7e205b7dc4
Whiteboard: [backed-out] → [fixed-in-fx-team]
|
||
Comment 7•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ae7e205b7dc4
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
You need to log in
before you can comment on or make changes to this bug.
Description
•