Add GC timing data for TI sweeping and XPConnect

RESOLVED FIXED in mozilla11

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 571519 [details] [diff] [review]
patch

This does as it says. It also makes it a little easier to add new fields without having to worry about column alignment.
Attachment #571519 - Flags: review?(cdleary)
(Assignee)

Updated

6 years ago
Assignee: general → wmccloskey
(Assignee)

Comment 1

6 years ago
Comment on attachment 571519 [details] [diff] [review]
patch

I had an idea for an improvement to this. I'll post a new patch soon.
Attachment #571519 - Flags: review?(cdleary)
(Assignee)

Comment 2

6 years ago
Created attachment 571762 [details] [diff] [review]
patch v2

This patch improves on the previous one by putting the MOZ_GCTIMER data into the Error Console (replacing the somewhat wrong data that was there before).

While I was at it, I also fixed the problem we have where we incorrectly think that all GCs are full GCs. With the fix, we will no longer run the cycle collector after a compartmental GC.

Gregor, do you have time to review this? Chris said his queue is pretty full.
Attachment #571519 - Attachment is obsolete: true
Attachment #571762 - Flags: review?(anygregor)
Attachment #571762 - Flags: review?(anygregor) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/698e6ec3467e
Target Milestone: --- → mozilla11
https://hg.mozilla.org/mozilla-central/rev/698e6ec3467e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
and follow-up
https://hg.mozilla.org/mozilla-central/rev/b5373c0d5a88

Comment 6

6 years ago
/me mumbles something about a patch to dom/ not getting a review from a DOM peer.

May I ask what the GC numbers mean ?

Comment 7

6 years ago
Especially, is the "Total" the total time in ms?
(Assignee)

Comment 8

6 years ago
(In reply to Olli Pettay [:smaug] from comment #6)
> /me mumbles something about a patch to dom/ not getting a review from a DOM
> peer.
> 
> May I ask what the GC numbers mean ?

Uh, sorry. I thought nsJSEnvironment.cpp was a special case.

The numbers are in milliseconds. I can add units, since I guess it is a little confusing. Mark and Sweep are the time to do marking and sweeping. The remaining numbers mostly just break down the sweeping number. +Chu and -Chu tell you how many GC chunks were allocated or freed since the last GC.
You need to log in before you can comment on or make changes to this bug.