Closed Bug 699298 Opened 8 years ago Closed 8 years ago

Add GC timing data for TI sweeping and XPConnect

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: billm, Assigned: billm)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
This does as it says. It also makes it a little easier to add new fields without having to worry about column alignment.
Attachment #571519 - Flags: review?(cdleary)
Assignee: general → wmccloskey
Comment on attachment 571519 [details] [diff] [review]
patch

I had an idea for an improvement to this. I'll post a new patch soon.
Attachment #571519 - Flags: review?(cdleary)
Attached patch patch v2Splinter Review
This patch improves on the previous one by putting the MOZ_GCTIMER data into the Error Console (replacing the somewhat wrong data that was there before).

While I was at it, I also fixed the problem we have where we incorrectly think that all GCs are full GCs. With the fix, we will no longer run the cycle collector after a compartmental GC.

Gregor, do you have time to review this? Chris said his queue is pretty full.
Attachment #571519 - Attachment is obsolete: true
Attachment #571762 - Flags: review?(anygregor)
Attachment #571762 - Flags: review?(anygregor) → review+
https://hg.mozilla.org/mozilla-central/rev/698e6ec3467e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
/me mumbles something about a patch to dom/ not getting a review from a DOM peer.

May I ask what the GC numbers mean ?
Especially, is the "Total" the total time in ms?
(In reply to Olli Pettay [:smaug] from comment #6)
> /me mumbles something about a patch to dom/ not getting a review from a DOM
> peer.
> 
> May I ask what the GC numbers mean ?

Uh, sorry. I thought nsJSEnvironment.cpp was a special case.

The numbers are in milliseconds. I can add units, since I guess it is a little confusing. Mark and Sweep are the time to do marking and sweeping. The remaining numbers mostly just break down the sweeping number. +Chu and -Chu tell you how many GC chunks were allocated or freed since the last GC.
You need to log in before you can comment on or make changes to this bug.