699298 - Add GC timing data for TI sweeping and XPConnect

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch

This does as it says. It also makes it a little easier to add new fields without having to worry about column alignment.

Comment 1

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 571519 [details] [diff] [review]
patch

I had an idea for an improvement to this. I'll post a new patch soon.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Attachment: patch v2

This patch improves on the previous one by putting the MOZ_GCTIMER data into the Error Console (replacing the somewhat wrong data that was there before).

While I was at it, I also fixed the problem we have where we incorrectly think that all GCs are full GCs. With the fix, we will no longer run the cycle collector after a compartmental GC.

Gregor, do you have time to review this? Chris said his queue is pretty full.

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/698e6ec3467e

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/698e6ec3467e

Comment 5

[Marco Bonardo [:mak]]

and follow-up
https://hg.mozilla.org/mozilla-central/rev/b5373c0d5a88

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

/me mumbles something about a patch to dom/ not getting a review from a DOM peer.

May I ask what the GC numbers mean ?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Especially, is the "Total" the total time in ms?

Comment 8

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

(In reply to Olli Pettay [:smaug] from comment #6)
> /me mumbles something about a patch to dom/ not getting a review from a DOM
> peer.
> 
> May I ask what the GC numbers mean ?

Uh, sorry. I thought nsJSEnvironment.cpp was a special case.

The numbers are in milliseconds. I can add units, since I guess it is a little confusing. Mark and Sweep are the time to do marking and sweeping. The remaining numbers mostly just break down the sweeping number. +Chu and -Chu tell you how many GC chunks were allocated or freed since the last GC.