699381 - Addon About dialog: extensionDetailsBox too small

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Axel Grude [:realRaven]]

Attachment: Addon-About.png

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
Build ID: 20110928134238

Steps to reproduce:

Open Addon-Manager click any extension that has a reasonable amount of "about" notes;  e.g. Zombie Keys or Tag Toolbar.

then select about from the context menu.


Actual results:

the dialog would be high enough for all the information but the top panel only uses half the space


Expected results:

extensionDetailsBox should have expanded to fill remaining dialog height.
This can be resolved by finding the contributorsBox (next sibling of extensionDetailsBox) and adding collapsed: true. Note: thereis another contributorsBox vbox element _within_ the extensiondDetailBox. I would also highly recommend making the dialog resizable

Comment 1

[Ludovic Hirlimann [:Usul]]

Hey Axel does it shows up in the same manner in Firefox ?

Comment 2

[Axel Grude [:realRaven]]

Yes it does. Also the patch (setting contributorsBox collapsed=true) works there as well. IMO the duplication of contributorsBox is possibly a bug in itself anyway.

interestingly, increasing the flex attribute for extensionDetailsBox does not alleviate the bug but makes it worse. (Windows XP Pro, Windowblinds Style "Element Default"). Can somebody with a XP Luna (standard UI skin) confirm?

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Could you test using the default theme, and attach a screenshot of that? Thanks.

Comment 4

[Axel Grude [:realRaven]]

Attachment: Default theme

Here is a screenshot using Thunderbird's default theme, you can clearly see the same effect. There is additional unused space underneath the about content.
I have made 2 version of the screenshot, once with Luna (default XP skin) and one with the WindowBlinds skin Eminence, to make sure this wasn't a side effect of my UI Skinning System.

Comment 5

[:aceman]

I do not see the problem on TB17 linux with the Quickfolders extension (as used in Axel's screenshot). The contributor box extends way down to the Close button.
And the dialog is resizable.
Can you retest it?

Comment 6

[Axel Grude [:realRaven]]

Attachment: Another test.. Earlybird 16

Problem still persists, in Windows XP (default theme)
Earlybird 16.0a2, (2012-07-28)
Here with a different addon (smartTemplate4)

Comment 7

[Axel Grude [:realRaven]]

Just tested in safe mode, which makes the bug disappear. Through elimination process, I found out that this is caused by the Quick LOcale Switcher Extension. It appears that this injects an additional contributorsBox _underneath_ the extensionDetailsBox.

Once I disable it, the about dialogs do not have the wasted space anymore.