699423 - about:sessionrestore session restore comes up empty

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect)

Description

[Wayne Mery (:wsmwk)]

Attachment: sessionstore after windows shutdown via windows update process

about:sessionrestore session restore comes up empty / blank.
i'm using recent trunk build 2011-11-01

sessionstore.js attached, is the state of the file after having restarted the PC following a windows update. Thus, Firefox was shut down in a normal manner.

Comment 1

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

about:sessionrestore is blank, but it looks like it was loaded directly, not via the normal post-crash process. If that's how you loaded it, then it being blank is expected.

I also see lastSessionState in there, which indicates that you had an update (or something addons related) which caused a Firefox restart... Your old session should have been available under "restore previous session".

All of this makes me thing you don't have startup set to restore previous windows & tabs.

Regardless, if "restore previous session isn't enabled", set browser.sessionstore.resume_session_once to true, quit, and move the attached file into sessionstore.js. Then start Firefox and it will be enabled (I just tested that it works).

I'm chalking your case up to a mixed bag of things not working exactly how you expected, but Firefox behaving "correctly". If you can reproduce this state though, we should look at it further.

Comment 2

[Wayne Mery (:wsmwk)]

(In reply to Paul O'Shannessy [:zpao] from comment #1)
> about:sessionrestore is blank, but it looks like it was loaded directly, not
> via the normal post-crash process. If that's how you loaded it, then it
> being blank is expected.
> 
> I also see lastSessionState in there, which indicates that you had an update
> (or something addons related) which caused a Firefox restart... Your old
> session should have been available under "restore previous session".
> 
> All of this makes me thing you don't have startup set to restore previous
> windows & tabs.

correctomundo. Subsequent to my restart and with some disappointment I found options were set to start to home page, not previous session tabs. how that happened i don't know. but anyway, I had hoped that changing the option. deleting sessionstore.js, and naming the old sessionstore file would bring back my tabs - because the attached file is not empty

 
> Regardless, if "restore previous session isn't enabled", set
> browser.sessionstore.resume_session_once to true, quit, and move the
> attached file into sessionstore.js. Then start Firefox and it will be
> enabled (I just tested that it works).

thanks for testing that.
however, no luck here. no love.
i even tried it in a new profile

only 3 items in console, including
Warning: XUL box for _moz_generated_content_after element contained an inline #text child, forcing all its children to be wrapped in a block.
Source File: chrome://browser/content/browser.xul
Line: 0 

any other ideas?

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

(In reply to Wayne Mery (:wsmwk) from comment #2)
> thanks for testing that.
> however, no luck here. no love.
> i even tried it in a new profile

Hmm, that definitely worked for me. I had Firefox set to restore session as well, but I don't think that should have mattered.

> any other ideas?

You can do some macroscopic surgery on the session file. Find lastSessionState, delete up to it's open brace ("...lastSessionState:") and then everything after the matching brace (looks like there's just 1 single close brace after)

Comment 4

[Wayne Mery (:wsmwk)]

(In reply to Paul O'Shannessy [:zpao] from comment #3)
> > any other ideas?
> 
> You can do some macroscopic surgery on the session file. Find
> lastSessionState, delete up to it's open brace ("...lastSessionState:") and
> then everything after the matching brace (looks like there's just 1 single
> close brace after)

awesome - that worked

Comment 5

[Michael Kohler [:mkohler]]

This doesn't seem to be a bug, can this bug be closed?

Comment 6

[Wayne Mery (:wsmwk)]

(In reply to Michael Kohler [:michaelkohler] from comment #5)
> This doesn't seem to be a bug, can this bug be closed?

It *was* a bug. Whether it still is a bug is perhaps your question?  My response is, I'm not sure if it has been fixed.

Comment 7

[Jonathan Watt [:jwatt]]

Note also bug 777272.

Comment 8

[Wayne Mery (:wsmwk)]

I haven't seen this in a long time.