Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Integrate RuleView into Highlighter Sidebar

RESOLVED FIXED in Firefox 10

Status

()

Firefox
Developer Tools
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: rc, Assigned: rc)

Tracking

unspecified
Firefox 10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [fixed-in-fx-team])

Attachments

(1 attachment, 4 obsolete attachments)

(Assignee)

Description

6 years ago
Add the cssRuleView to the Highlighter's Sidebar.
(Assignee)

Comment 1

6 years ago
Created attachment 571709 [details] [diff] [review]
WIP 1
Assignee: nobody → rcampbell
Status: NEW → ASSIGNED
(Assignee)

Comment 2

6 years ago
Created attachment 571728 [details] [diff] [review]
WIP 2

behavior seems to be fixed, added entries to inspector.properties for strings. Just haven't checked the tests yet.
Attachment #571709 - Attachment is obsolete: true
(Assignee)

Comment 3

6 years ago
Created attachment 571761 [details] [diff] [review]
RuleView in Sidebar

Updated patch, added unittests, cleanup code and improved functionality.
Attachment #571728 - Attachment is obsolete: true
Attachment #571761 - Flags: review?(dcamp)

Updated

6 years ago
Attachment #571761 - Flags: review?(dcamp) → review+
(Assignee)

Comment 4

6 years ago
Created attachment 571776 [details]
Mac Screenshot
(Assignee)

Comment 5

6 years ago
Comment on attachment 571776 [details]
Mac Screenshot

wrong place for the screenshot.
Attachment #571776 - Attachment is obsolete: true
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/integration/fx-team/rev/b878369ab3c8
Whiteboard: [fixed-in-fx-team]
(Assignee)

Comment 7

6 years ago
https://hg.mozilla.org/integration/fx-team/rev/87ce80260f22
Whiteboard: [fixed-in-fx-team] → [backed-out]
(Assignee)

Comment 8

6 years ago
Created attachment 571994 [details] [diff] [review]
RuleView in Sidebar 2

Updated version. More tests. Checks for and disables extra set buttons in sidebar. Tests tab switching with sidebar tools active.
Attachment #571761 - Attachment is obsolete: true
Attachment #571994 - Flags: review?(dcamp)
(Assignee)

Comment 9

6 years ago
current try build running here:

https://tbpl.mozilla.org/?tree=Try&rev=4bfaea2d57cb

Updated

6 years ago
Attachment #571994 - Flags: review?(dcamp) → review+
(Assignee)

Comment 10

6 years ago
relanded:

https://hg.mozilla.org/integration/fx-team/rev/482f32dcd1eb
Whiteboard: [backed-out] → [fixed-in-fx-team]
(Assignee)

Comment 11

6 years ago
https://hg.mozilla.org/mozilla-central/rev/482f32dcd1eb
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
You need to log in before you can comment on or make changes to this bug.