Closed Bug 699516 Opened 8 years ago Closed 8 years ago

Rename WEBKIT_lose_context to WEBGL_EXT_lose_context

Categories

(Core :: Canvas: WebGL, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: bjacob, Assigned: bjacob)

Details

Attachments

(1 file, 2 obsolete files)

Attached patch rename to MOZ_lose_context (obsolete) — Splinter Review
Jeff M mentioned that it's actually a bad idea for us to expose WEBKIT_ prefixed extensions, and it's better for everybody to rename them to MOZ_. The idea is that this way, web devs can rely on WEBKIT_ stuff being actually, bug for bug, WebKit, rather than having to use e.g. user agent strings.
Attachment #571732 - Flags: review?(dsherk)
But as per the khronos list discussion, since we're using the same standard as WebKit, shouldn't we be naming this EXT_?
Comment on attachment 571732 [details] [diff] [review]
rename to MOZ_lose_context

Review of attachment 571732 [details] [diff] [review]:
-----------------------------------------------------------------

Did you try building this? I think WebGLContext.h:529 was missed.
Attachment #571732 - Flags: review?(dsherk) → review-
Attached patch rename to MOZ_lose_context (obsolete) — Splinter Review
Attachment #571732 - Attachment is obsolete: true
Attachment #571739 - Flags: review+
I just had another conversation with jrmuizel and there was a misunderstanding. He thought that was a prefix on a function name. For GL extensions, the norm is for vendors to use each others' extensions without renaming them, so we can stick with that.

-> not landing this patch for now.

However we still want to rename this to WEBGL_ or WEBGL_EXT_ soon.
(In reply to Jeff Gilbert [:jgilbert] from comment #1)
> But as per the khronos list discussion, since we're using the same standard
> as WebKit, shouldn't we be naming this EXT_?

I would like to bring this up in the next conference call. Unfortunately today's got cancelled, next one is in 2 weeks.
Summary: Rename WEBKIT_lose_context to MOZ_lose_context → Rename WEBKIT_lose_context to WEBGL_EXT_lose_context
Per public_webgl list discussion, we're switching to WEBGL_EXT_ now.
Attachment #571739 - Attachment is obsolete: true
Attachment #571847 - Flags: review?(dsherk)
Attachment #571847 - Flags: review?(dsherk) → review+
https://hg.mozilla.org/mozilla-central/rev/2964292c2dc7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.