699516 - Rename WEBKIT_lose_context to WEBGL_EXT_lose_context

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: rename to MOZ_lose_context

Jeff M mentioned that it's actually a bad idea for us to expose WEBKIT_ prefixed extensions, and it's better for everybody to rename them to MOZ_. The idea is that this way, web devs can rely on WEBKIT_ stuff being actually, bug for bug, WebKit, rather than having to use e.g. user agent strings.

Comment 1

[Kelsey Gilbert [:jgilbert]]

But as per the khronos list discussion, since we're using the same standard as WebKit, shouldn't we be naming this EXT_?

Comment 2

[Doug Sherk (:drs) (inactive)]

Comment on attachment 571732 [details] [diff] [review]
rename to MOZ_lose_context

Review of attachment 571732 [details] [diff] [review]:
-----------------------------------------------------------------

Did you try building this? I think WebGLContext.h:529 was missed.

Comment 3

[Doug Sherk (:drs) (inactive)]

Attachment: rename to MOZ_lose_context

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

I just had another conversation with jrmuizel and there was a misunderstanding. He thought that was a prefix on a function name. For GL extensions, the norm is for vendors to use each others' extensions without renaming them, so we can stick with that.

-> not landing this patch for now.

However we still want to rename this to WEBGL_ or WEBGL_EXT_ soon.

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

(In reply to Jeff Gilbert [:jgilbert] from comment #1)
> But as per the khronos list discussion, since we're using the same standard
> as WebKit, shouldn't we be naming this EXT_?

I would like to bring this up in the next conference call. Unfortunately today's got cancelled, next one is in 2 weeks.

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: rename to WEBGL_EXT_lose_context

Per public_webgl list discussion, we're switching to WEBGL_EXT_ now.

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/2964292c2dc7

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/2964292c2dc7