699592 - Would like a way to ask if a property is inherited by default

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Dave Camp (:dcamp)]

Attachment: maybe this will work

We're working on a developer tool (similar to firebug's) that shows the css rules that apply to an element. It shows properties from cssText for rules returned from nsIDOMUtils::getCSSStyleRules(). For parent elements, we want to show only properties whose value might be inherited.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 571788 [details] [diff] [review]
maybe this will work

>+++ b/layout/inspector/src/inDOMUtils.cpp
>+  *_retval = (sid < nsStyleStructID_Reset_Start);

How about:

  *_retval = !nsCachedStyleData::IsReset(sid);

?  You'll need to include nsRuleNode.h.

r=me with that.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 571788 [details] [diff] [review]
maybe this will work

Actually, wait.  This will break for shorthands because kSIDTable only goes up to eCSSProperty_COUNT_no_shorthands.

You need to handle shorthands specially (e.g by setting |prop| to one of the longhands the shorthand expands to).

And please add some tests (including for the above) and a commit message?

Comment 3

[Dave Camp (:dcamp)]

Attachment: v2

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 572093 [details] [diff] [review]
v2

r=me

Comment 5

[Dave Camp (:dcamp)]

https://hg.mozilla.org/integration/fx-team/rev/56e7358abdb3

Comment 6

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/56e7358abdb3