Closed Bug 699672 Opened 15 years ago Closed 14 years ago

The SEC_ASN1Template declarations in secmodt.h are not C++ safe

Categories

(NSS :: Libraries, defect, P2)

3.13
defect

Tracking

(Not tracked)

RESOLVED FIXED
3.13.3

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(1 file)

Attached patch Proposed patch — — Splinter Review
secmodt.h declares several SEC_ASN1Templates and their chooser functions, but these declarations are not inside a SEC_BEGIN_PROTOS/SEC_END_PROTOS block, so their names may be mangled incorrectly when included in C++. The patch adds SEC_BEGIN_PROTOS and SEC_END_PROTOS around the SEC_ASN1Template declarations in secmodt.h. It also uses the SEC_ASN1_CHOOSER_DECLARE macro to declare the chooser functions, to be consistent with how NSS headers declare them.
Attachment #571855 - Flags: review?(rrelyea)
Attachment #571855 - Flags: feedback?(mattm)
Comment on attachment 571855 [details] [diff] [review] Proposed patch Tested by patching into NSS and removing our include workaround.
Attachment #571855 - Flags: feedback?(mattm) → feedback+
Comment on attachment 571855 [details] [diff] [review] Proposed patch r+ rrelyea
Attachment #571855 - Flags: review?(rrelyea) → review+
Patch checked in on the NSS trunk (NSS 3.13.3). Checking in secmodt.h; /cvsroot/mozilla/security/nss/lib/softoken/secmodt.h,v <-- secmodt.h new revision: 1.41; previous revision: 1.40 done
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: 3.13.2 → 3.13.3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: