Remove an unused argument to ino2name in {js/src/,}config/pathsub.{c,h}

RESOLVED FIXED in mozilla10

Status

()

Core
Build Config
--
trivial
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Waldo, Assigned: Waldo)

Tracking

Trunk
mozilla10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 571871 [details] [diff] [review]
Patch

Clang warns about this when I build the JS shell.  I'd like to silence it.

There are four (count 'em) different copies of pathsub.{c,h} in the tree: these two, one in NSPR, and one in NSS.  I'm pretty sure I shouldn't touch the NSPR one.  I'm less certain about NSS but am erring on the side of caution.
Attachment #571871 - Flags: review?(ted.mielczarek)
Comment on attachment 571871 [details] [diff] [review]
Patch

Review of attachment 571871 [details] [diff] [review]:
-----------------------------------------------------------------

I don't claim to really know what all this code is doing, but this seems trivially correct.
Attachment #571871 - Flags: review?(ted.mielczarek) → review+
That makes two of us.  :-)  An unused variable has no relevance, so...yeah.

https://hg.mozilla.org/integration/mozilla-inbound/rev/be3714af7869
Target Milestone: --- → mozilla10
Summary: Remove an unused argument to ino2name in {js/src/,}config/pathsub.{c,} → Remove an unused argument to ino2name in {js/src/,}config/pathsub.{c,h}

Comment 3

6 years ago
https://hg.mozilla.org/mozilla-central/rev/be3714af7869
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.