Closed
Bug 699691
Opened 14 years ago
Closed 14 years ago
Remove an unused argument to ino2name in {js/src/,}config/pathsub.{c,h}
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla10
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
|
2.15 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Clang warns about this when I build the JS shell. I'd like to silence it.
There are four (count 'em) different copies of pathsub.{c,h} in the tree: these two, one in NSPR, and one in NSS. I'm pretty sure I shouldn't touch the NSPR one. I'm less certain about NSS but am erring on the side of caution.
Attachment #571871 -
Flags: review?(ted.mielczarek)
|
||
Comment 1•14 years ago
|
||
Comment on attachment 571871 [details] [diff] [review]
Patch
Review of attachment 571871 [details] [diff] [review]:
-----------------------------------------------------------------
I don't claim to really know what all this code is doing, but this seems trivially correct.
Attachment #571871 -
Flags: review?(ted.mielczarek) → review+
|
Assignee | |
Comment 2•14 years ago
|
||
That makes two of us. :-) An unused variable has no relevance, so...yeah.
https://hg.mozilla.org/integration/mozilla-inbound/rev/be3714af7869
Target Milestone: --- → mozilla10
|
|
Assignee | |
Updated•14 years ago
|
Summary: Remove an unused argument to ino2name in {js/src/,}config/pathsub.{c,} → Remove an unused argument to ino2name in {js/src/,}config/pathsub.{c,h}
|
||
Comment 3•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•