Last Comment Bug 699691 - Remove an unused argument to ino2name in {js/src/,}config/pathsub.{c,h}
: Remove an unused argument to ino2name in {js/src/,}config/pathsub.{c,h}
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: mozilla10
Assigned To: Jeff Walden [:Waldo] (remove +bmo to email)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-11-03 19:24 PDT by Jeff Walden [:Waldo] (remove +bmo to email)
Modified: 2011-11-08 01:14 PST (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (2.15 KB, patch)
2011-11-03 19:24 PDT, Jeff Walden [:Waldo] (remove +bmo to email)
ted: review+
Details | Diff | Splinter Review

Description Jeff Walden [:Waldo] (remove +bmo to email) 2011-11-03 19:24:48 PDT
Created attachment 571871 [details] [diff] [review]
Patch

Clang warns about this when I build the JS shell.  I'd like to silence it.

There are four (count 'em) different copies of pathsub.{c,h} in the tree: these two, one in NSPR, and one in NSS.  I'm pretty sure I shouldn't touch the NSPR one.  I'm less certain about NSS but am erring on the side of caution.
Comment 1 Ted Mielczarek [:ted.mielczarek] 2011-11-07 12:55:51 PST
Comment on attachment 571871 [details] [diff] [review]
Patch

Review of attachment 571871 [details] [diff] [review]:
-----------------------------------------------------------------

I don't claim to really know what all this code is doing, but this seems trivially correct.
Comment 2 Jeff Walden [:Waldo] (remove +bmo to email) 2011-11-07 17:55:34 PST
That makes two of us.  :-)  An unused variable has no relevance, so...yeah.

https://hg.mozilla.org/integration/mozilla-inbound/rev/be3714af7869
Comment 3 Ed Morley [:emorley] 2011-11-08 01:14:41 PST
https://hg.mozilla.org/mozilla-central/rev/be3714af7869

Note You need to log in before you can comment on or make changes to this bug.