Scroll open tab into view when the tab list is opened

VERIFIED FIXED

Status

()

Firefox for Android
General
P3
normal
VERIFIED FIXED
6 years ago
a year ago

People

(Reporter: kbrosnan, Assigned: sriram)

Tracking

unspecified
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
When opening the tab bar your current tab is noted by being bold. Clicking on the tab drop down may not display the currently selected tab if you have more than 9 tabs open in portrait mode or 5 tabs in landscape on my g2.
Summary: Make sure the open tab is visible when the tab list is opened → Scroll open tab into view when the tab list is opened
Assignee: nobody → sriram

Updated

6 years ago
Priority: -- → P3
(Assignee)

Comment 1

6 years ago
Created attachment 572993 [details] [diff] [review]
Patch

The tabs list is scrolled to the selected tab when showed first.
The tabs list still scrolls to top -- which will be fixed as a part of Bug 697098.
Attachment #572993 - Flags: review?(mark.finkle)
Comment on attachment 572993 [details] [diff] [review]
Patch


>diff --git a/embedding/android/TabsTray.java b/embedding/android/TabsTray.java

>+        public int getSelectedTabPosition() {
>+            if (mTabs == null)
>+                return -1;
>+
>+            return mTabs.indexOf(Tabs.getInstance().getSelectedTab());
>+        }

Let's be a little more generic here:

getPositionForTab(Tab tab) {
    ...
    return mTabs.indexOf(tab);
}

r+ otherwise. I can change on checkin
Attachment #572993 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/projects/birch/rev/64ec37a61326
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 4

6 years ago
Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111108 Firefox/10.0a1 Fennec/10.0a1 - Native Fennec build
Device: HTC Desire Z - Android 2.3

The tabs list is scrolled to the selected tab when showed first., verified in both landscape and portrait.
Status: RESOLVED → VERIFIED
These patches were backed while investigating Talos failures.  Now that tests are green again, we will need to reland.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
backout was backed out https://hg.mozilla.org/projects/birch/rev/6f925b45a547
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED

Comment 7

6 years ago
Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111114 Firefox/10.0a1 Fennec/10.0a1 - Native Fennec build
Device: HTC Desire Z - Android 2.3

The tabs list is scrolled to the selected tab when showed first., verified in both landscape and portrait.
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed

Updated

6 years ago
Depends on: 718267
You need to log in before you can comment on or make changes to this bug.