Remove PR_INT64_MAX / PR_UINT64_MAX from non-nsprpub source

RESOLVED FIXED in mozilla12

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: m_kato, Assigned: Ms2ger)

Tracking

(Blocks: 1 bug)

Trunk
mozilla12
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 5 obsolete attachments)

(Reporter)

Description

6 years ago
nsprpub has PR_UINT64_MAX by bug 674277.   We should remove this due to duplicated define.

    content/media/VideoUtils.h (View Hg log or Hg annotations)
        line 63 -- #define PR_UINT64_MAX (~(PRUint64)(0)) 
    content/base/public/nsDOMFile.h (View Hg log or Hg annotations)
        line 59 -- #define PR_UINT64_MAX (~(PRUint64)(0))
Note that if we do this, we'll have to change our NSPR requirement to version 4.9.
(Assignee)

Comment 2

6 years ago
Created attachment 572323 [details] [diff] [review]
Part a: VideoUtils
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
Attachment #572323 - Flags: review?(chris)
(Assignee)

Comment 3

6 years ago
Created attachment 572324 [details] [diff] [review]
Part b: nsDOMBlobBuilder
Attachment #572324 - Flags: review?(khuey)
(Assignee)

Updated

6 years ago
Blocks: 187528
Attachment #572323 - Flags: review?(chris) → review+
Attachment #572324 - Flags: review?(khuey) → review+
(Assignee)

Comment 4

6 years ago
(In reply to Ted Mielczarek [:ted, :luser] from comment #1)
> Note that if we do this, we'll have to change our NSPR requirement to
> version 4.9.

Would appreciate a pointer to the code that needs to change here.
It's just in configure:
http://mxr.mozilla.org/mozilla-central/source/configure.in#4194
(Assignee)

Comment 6

6 years ago
Created attachment 572598 [details] [diff] [review]
Part c: configure
Attachment #572598 - Flags: review?(ted.mielczarek)
Comment on attachment 572598 [details] [diff] [review]
Part c: configure

Review of attachment 572598 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine, but let's please hold off on landing this until we actually get a NSPR 4.9 release out the door.
Attachment #572598 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 8

6 years ago
Created attachment 573571 [details] [diff] [review]
Part d: RasterImage
Attachment #573571 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #573571 - Flags: review? → review?(joe)
(Assignee)

Comment 9

6 years ago
Created attachment 573575 [details] [diff] [review]
Part d: RasterImage

And now non-empty.
Attachment #573571 - Attachment is obsolete: true
Attachment #573571 - Flags: review?(joe)
Attachment #573575 - Flags: review?(joe)
Attachment #573575 - Flags: review?(joe) → review+
Just a ping on this wondering what the status is - since the review are passed, is this just waiting to be checked in?
See comment 7?
(Assignee)

Comment 12

6 years ago
Created attachment 584469 [details] [diff] [review]
Patch v2: StdInt.h

I think this will be a more efficient approach than waiting until NSPR moves. (We might have moved Gecko off its integer types by then.)
Attachment #572323 - Attachment is obsolete: true
Attachment #572324 - Attachment is obsolete: true
Attachment #572598 - Attachment is obsolete: true
Attachment #573575 - Attachment is obsolete: true
Attachment #584469 - Flags: review?(ted.mielczarek)
Attachment #584469 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 13

6 years ago
https://hg.mozilla.org/mozilla-central/rev/1fd016e84537
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in before you can comment on or make changes to this bug.