Remove PR_INT64_MAX / PR_UINT64_MAX from non-nsprpub source

RESOLVED FIXED in mozilla12

Status

defect
RESOLVED FIXED
8 years ago
Last year

People

(Reporter: m_kato, Assigned: Ms2ger)

Tracking

(Blocks 1 bug)

Trunk
mozilla12
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(1 attachment, 5 obsolete attachments)

Reporter

Description

8 years ago
nsprpub has PR_UINT64_MAX by bug 674277.   We should remove this due to duplicated define.

    content/media/VideoUtils.h (View Hg log or Hg annotations)
        line 63 -- #define PR_UINT64_MAX (~(PRUint64)(0)) 
    content/base/public/nsDOMFile.h (View Hg log or Hg annotations)
        line 59 -- #define PR_UINT64_MAX (~(PRUint64)(0))
Note that if we do this, we'll have to change our NSPR requirement to version 4.9.
Assignee

Comment 2

8 years ago
Posted patch Part a: VideoUtils (obsolete) — Splinter Review
Assignee: nobody → Ms2ger
Status: NEW → ASSIGNED
Attachment #572323 - Flags: review?(chris)
Assignee

Comment 3

8 years ago
Posted patch Part b: nsDOMBlobBuilder (obsolete) — Splinter Review
Attachment #572324 - Flags: review?(khuey)
Assignee

Updated

8 years ago
Blocks: buildwarning
Attachment #572323 - Flags: review?(chris) → review+
Assignee

Comment 4

8 years ago
(In reply to Ted Mielczarek [:ted, :luser] from comment #1)
> Note that if we do this, we'll have to change our NSPR requirement to
> version 4.9.

Would appreciate a pointer to the code that needs to change here.
Assignee

Comment 6

8 years ago
Posted patch Part c: configure (obsolete) — Splinter Review
Attachment #572598 - Flags: review?(ted.mielczarek)
Comment on attachment 572598 [details] [diff] [review]
Part c: configure

Review of attachment 572598 [details] [diff] [review]:
-----------------------------------------------------------------

This is fine, but let's please hold off on landing this until we actually get a NSPR 4.9 release out the door.
Attachment #572598 - Flags: review?(ted.mielczarek) → review+
Assignee

Comment 8

8 years ago
Posted patch Part d: RasterImage (obsolete) — Splinter Review
Attachment #573571 - Flags: review?
Assignee

Updated

8 years ago
Attachment #573571 - Flags: review? → review?(joe)
Assignee

Comment 9

8 years ago
Posted patch Part d: RasterImage (obsolete) — Splinter Review
And now non-empty.
Attachment #573571 - Attachment is obsolete: true
Attachment #573571 - Flags: review?(joe)
Attachment #573575 - Flags: review?(joe)
Attachment #573575 - Flags: review?(joe) → review+
Just a ping on this wondering what the status is - since the review are passed, is this just waiting to be checked in?
I think this will be a more efficient approach than waiting until NSPR moves. (We might have moved Gecko off its integer types by then.)
Attachment #572323 - Attachment is obsolete: true
Attachment #572324 - Attachment is obsolete: true
Attachment #572598 - Attachment is obsolete: true
Attachment #573575 - Attachment is obsolete: true
Attachment #584469 - Flags: review?(ted.mielczarek)
Attachment #584469 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/1fd016e84537
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.