Closed
Bug 699731
Opened 14 years ago
Closed 14 years ago
Remove PR_INT64_MAX / PR_UINT64_MAX from non-nsprpub source
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla12
People
(Reporter: m_kato, Assigned: Ms2ger)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file, 5 obsolete files)
|
21.48 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
nsprpub has PR_UINT64_MAX by bug 674277. We should remove this due to duplicated define.
content/media/VideoUtils.h (View Hg log or Hg annotations)
line 63 -- #define PR_UINT64_MAX (~(PRUint64)(0))
content/base/public/nsDOMFile.h (View Hg log or Hg annotations)
line 59 -- #define PR_UINT64_MAX (~(PRUint64)(0))
|
||
Comment 1•14 years ago
|
||
Note that if we do this, we'll have to change our NSPR requirement to version 4.9.
|
Assignee | |
Comment 2•14 years ago
|
||
|
|
Assignee | |
Comment 3•14 years ago
|
||
Attachment #572324 -
Flags: review?(khuey)
|
|
Assignee | |
Updated•14 years ago
|
Blocks: buildwarning
|
||
Updated•14 years ago
|
Attachment #572323 -
Flags: review?(chris) → review+
Attachment #572324 -
Flags: review?(khuey) → review+
|
|
Assignee | |
Comment 4•14 years ago
|
||
(In reply to Ted Mielczarek [:ted, :luser] from comment #1)
> Note that if we do this, we'll have to change our NSPR requirement to
> version 4.9.
Would appreciate a pointer to the code that needs to change here.
|
|
||
Comment 5•14 years ago
|
||
It's just in configure:
http://mxr.mozilla.org/mozilla-central/source/configure.in#4194
|
|
Assignee | |
Comment 6•14 years ago
|
||
Attachment #572598 -
Flags: review?(ted.mielczarek)
|
|
||
Comment 7•14 years ago
|
||
Comment on attachment 572598 [details] [diff] [review]
Part c: configure
Review of attachment 572598 [details] [diff] [review]:
-----------------------------------------------------------------
This is fine, but let's please hold off on landing this until we actually get a NSPR 4.9 release out the door.
Attachment #572598 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 8•14 years ago
|
||
Attachment #573571 -
Flags: review?
|
|
Assignee | |
Updated•14 years ago
|
Attachment #573571 -
Flags: review? → review?(joe)
|
|
Assignee | |
Comment 9•14 years ago
|
||
And now non-empty.
Attachment #573571 -
Attachment is obsolete: true
Attachment #573571 -
Flags: review?(joe)
Attachment #573575 -
Flags: review?(joe)
|
||
Updated•14 years ago
|
Attachment #573575 -
Flags: review?(joe) → review+
|
||
Comment 10•14 years ago
|
||
Just a ping on this wondering what the status is - since the review are passed, is this just waiting to be checked in?
See comment 7?
|
|
Assignee | |
Comment 12•14 years ago
|
||
I think this will be a more efficient approach than waiting until NSPR moves. (We might have moved Gecko off its integer types by then.)
Attachment #572323 -
Attachment is obsolete: true
Attachment #572324 -
Attachment is obsolete: true
Attachment #572598 -
Attachment is obsolete: true
Attachment #573575 -
Attachment is obsolete: true
Attachment #584469 -
Flags: review?(ted.mielczarek)
|
|
||
Updated•14 years ago
|
Attachment #584469 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 13•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
|
||
Updated•8 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•