Closed
Bug 699742
Opened 13 years ago
Closed 13 years ago
battery.level should be a double
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla11
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(4 files)
3.25 KB,
patch
|
sicking
:
review+
asa
:
approval-mozilla-aurora-
|
Details | Diff | Splinter Review |
585 bytes,
patch
|
cjones
:
review+
asa
:
approval-mozilla-aurora-
|
Details | Diff | Splinter Review |
1.90 KB,
patch
|
cjones
:
review+
asa
:
approval-mozilla-aurora-
|
Details | Diff | Splinter Review |
11.63 KB,
patch
|
cjones
:
review+
asa
:
approval-mozilla-aurora-
|
Details | Diff | Splinter Review |
The specs required a float but a double seems better.
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #572421 -
Flags: review?(jonas)
Assignee | ||
Comment 2•13 years ago
|
||
Attachment #572422 -
Flags: review?(jones.chris.g)
Assignee | ||
Comment 3•13 years ago
|
||
Attachment #572423 -
Flags: review?(jones.chris.g)
Assignee | ||
Comment 4•13 years ago
|
||
It happens that Android backend level always has 2 digits after the comma (with my phone) but it's better to use a double given that it doesn't cost a lot and some Android versions/implementations might have a more precise value.
Attachment #572425 -
Flags: review?(jones.chris.g)
Assignee | ||
Updated•13 years ago
|
Whiteboard: [needs review]
Comment on attachment 572421 [details] [diff] [review] Part A - Change in DOM code Review of attachment 572421 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #572421 -
Flags: review?(jonas) → review+
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #0) > The specs required a float but a double seems better. Why is that? So that it fits the natural JS value representation?
The code all looks fine.
Assignee | ||
Comment 8•13 years ago
|
||
(In reply to Chris Jones [:cjones] [:warhammer] from comment #6) > (In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #0) > > The specs required a float but a double seems better. > > Why is that? So that it fits the natural JS value representation? Yes.
OK.
Updated•13 years ago
|
Attachment #572422 -
Flags: review?(jones.chris.g) → review+
Updated•13 years ago
|
Attachment #572423 -
Flags: review?(jones.chris.g) → review+
Updated•13 years ago
|
Attachment #572425 -
Flags: review?(jones.chris.g) → review+
Assignee | ||
Updated•13 years ago
|
Flags: in-testsuite?
Whiteboard: [needs review]
Assignee | ||
Updated•13 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 10•13 years ago
|
||
Comment on attachment 572421 [details] [diff] [review] Part A - Change in DOM code This has just landed in mozilla-inbound. Requesting aurora approval for API completeness in Firefox 10. It would be better to ship Firefox 10 with the entire API if we say it is present. The risk is very low given that there is no use of the API for the moment.
Attachment #572421 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•13 years ago
|
Attachment #572422 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•13 years ago
|
Attachment #572423 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•13 years ago
|
Attachment #572425 -
Flags: approval-mozilla-aurora?
Comment 11•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ebe48efe95c5 https://hg.mozilla.org/mozilla-central/rev/538d80f3cf0e https://hg.mozilla.org/mozilla-central/rev/08f0c3b98c52 https://hg.mozilla.org/mozilla-central/rev/090456585da8
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Comment 12•13 years ago
|
||
Comment on attachment 572421 [details] [diff] [review] Part A - Change in DOM code It looks like this feature wasn't ready for 10. Please re-nominate if you have a good justification for trying to get this into 10 rather than just waiting for 11.
Attachment #572421 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Updated•13 years ago
|
Attachment #572422 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Updated•13 years ago
|
Attachment #572423 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Updated•13 years ago
|
Attachment #572425 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•