The default bug view has changed. See this FAQ.

battery.level should be a double

RESOLVED FIXED in mozilla11

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
mozilla11
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

6 years ago
The specs required a float but a double seems better.
(Assignee)

Comment 1

6 years ago
Created attachment 572421 [details] [diff] [review]
Part A - Change in DOM code
Attachment #572421 - Flags: review?(jonas)
(Assignee)

Comment 2

6 years ago
Created attachment 572422 [details] [diff] [review]
Part B - Change in hal code
Attachment #572422 - Flags: review?(jones.chris.g)
(Assignee)

Comment 3

6 years ago
Created attachment 572423 [details] [diff] [review]
Part C - Change in upower backend
Attachment #572423 - Flags: review?(jones.chris.g)
(Assignee)

Comment 4

6 years ago
Created attachment 572425 [details] [diff] [review]
Part D - Change in android backend

It happens that Android backend level always has 2 digits after the comma (with my phone) but it's better to use a double given that it doesn't cost a lot and some Android versions/implementations might have a more precise value.
Attachment #572425 - Flags: review?(jones.chris.g)
(Assignee)

Updated

6 years ago
Whiteboard: [needs review]
Comment on attachment 572421 [details] [diff] [review]
Part A - Change in DOM code

Review of attachment 572421 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #572421 - Flags: review?(jonas) → review+
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #0)
> The specs required a float but a double seems better.

Why is that?  So that it fits the natural JS value representation?
The code all looks fine.
(Assignee)

Comment 8

6 years ago
(In reply to Chris Jones [:cjones] [:warhammer] from comment #6)
> (In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #0)
> > The specs required a float but a double seems better.
> 
> Why is that?  So that it fits the natural JS value representation?

Yes.
OK.
Attachment #572422 - Flags: review?(jones.chris.g) → review+
Attachment #572423 - Flags: review?(jones.chris.g) → review+
Attachment #572425 - Flags: review?(jones.chris.g) → review+
(Assignee)

Updated

6 years ago
Flags: in-testsuite?
Whiteboard: [needs review]
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 10

6 years ago
Comment on attachment 572421 [details] [diff] [review]
Part A - Change in DOM code

This has just landed in mozilla-inbound. Requesting aurora approval for API completeness in Firefox 10. It would be better to ship Firefox 10 with the entire API if we say it is present. The risk is very low given that there is no use of the API for the moment.
Attachment #572421 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

6 years ago
Attachment #572422 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

6 years ago
Attachment #572423 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

6 years ago
Attachment #572425 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/ebe48efe95c5
https://hg.mozilla.org/mozilla-central/rev/538d80f3cf0e
https://hg.mozilla.org/mozilla-central/rev/08f0c3b98c52
https://hg.mozilla.org/mozilla-central/rev/090456585da8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11

Comment 12

5 years ago
Comment on attachment 572421 [details] [diff] [review]
Part A - Change in DOM code

It looks like this feature wasn't ready for 10. Please re-nominate if you have a good justification for trying to get this into 10 rather than just waiting for 11.
Attachment #572421 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-

Updated

5 years ago
Attachment #572422 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-

Updated

5 years ago
Attachment #572423 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-

Updated

5 years ago
Attachment #572425 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
You need to log in before you can comment on or make changes to this bug.