Closed Bug 699742 Opened 8 years ago Closed 8 years ago

battery.level should be a double

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla11

People

(Reporter: mounir, Assigned: mounir)

References

Details

Attachments

(4 files)

The specs required a float but a double seems better.
Attachment #572421 - Flags: review?(jonas)
Attachment #572422 - Flags: review?(jones.chris.g)
Attachment #572423 - Flags: review?(jones.chris.g)
It happens that Android backend level always has 2 digits after the comma (with my phone) but it's better to use a double given that it doesn't cost a lot and some Android versions/implementations might have a more precise value.
Attachment #572425 - Flags: review?(jones.chris.g)
Whiteboard: [needs review]
Comment on attachment 572421 [details] [diff] [review]
Part A - Change in DOM code

Review of attachment 572421 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #572421 - Flags: review?(jonas) → review+
(In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #0)
> The specs required a float but a double seems better.

Why is that?  So that it fits the natural JS value representation?
(In reply to Chris Jones [:cjones] [:warhammer] from comment #6)
> (In reply to Mounir Lamouri (:volkmar) (:mounir) from comment #0)
> > The specs required a float but a double seems better.
> 
> Why is that?  So that it fits the natural JS value representation?

Yes.
Attachment #572422 - Flags: review?(jones.chris.g) → review+
Attachment #572423 - Flags: review?(jones.chris.g) → review+
Attachment #572425 - Flags: review?(jones.chris.g) → review+
Flags: in-testsuite?
Whiteboard: [needs review]
Status: NEW → ASSIGNED
Comment on attachment 572421 [details] [diff] [review]
Part A - Change in DOM code

This has just landed in mozilla-inbound. Requesting aurora approval for API completeness in Firefox 10. It would be better to ship Firefox 10 with the entire API if we say it is present. The risk is very low given that there is no use of the API for the moment.
Attachment #572421 - Flags: approval-mozilla-aurora?
Attachment #572422 - Flags: approval-mozilla-aurora?
Attachment #572423 - Flags: approval-mozilla-aurora?
Attachment #572425 - Flags: approval-mozilla-aurora?
Comment on attachment 572421 [details] [diff] [review]
Part A - Change in DOM code

It looks like this feature wasn't ready for 10. Please re-nominate if you have a good justification for trying to get this into 10 rather than just waiting for 11.
Attachment #572421 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Attachment #572422 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Attachment #572423 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Attachment #572425 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.