We have a separate database that holds favicons urls that should be cleared when user clears its browsing history data.
Created attachment 573269 [details] [diff] [review] Clear favicon urls database when history is cleared
These patches were backed while investigating Talos failures. Now that tests are green again, we will need to reland.
backout was backed out https://hg.mozilla.org/projects/birch/rev/6f925b45a547
Where are the tests for this?
Question: should all favicons icons be cleared? What about the default bookmarks and search engines?
(In reply to Damon Sicore (:damons) from comment #5) > Where are the tests for this? Damon, we don't have a unit test infra in place to start adding tests yet. I'd suggest to file a bug to add the infra for tests on native UI and set a high priority for it.
(In reply to Naoki Hirata :nhirata from comment #6) > Question: should all favicons icons be cleared? What about the default > bookmarks and search engines? The favicon images won't be removed for bookmarks because their entries in the database are kept. This means that the favicons should still be visible in the bookmarks tab even after history is cleared. What will happen though is that the favicon URLs for the bookmarks will be cleared. So when they are accessed for the first time after history was cleared, the favicon will be downloaded again even though the image is still present in the database (which is not a big deal).
20111114041052 http://hg.mozilla.org/projects/birch/rev/859ecdfe0168 Samsung Galaxy SII (Android 2.3.4)
This patch was reverted in birch as part of the backout, but never got put back because the commits following the backout-of-the-backout used a different changeset as parent. The code is NOT in m-c now and the patch should be re-landed.
Reopening, see my previous comment.
Comment on attachment 573269 [details] [diff] [review] Clear favicon urls database when history is cleared This patch clears data that is supposed to be removed when history is cleared.
Comment on attachment 573269 [details] [diff] [review] Clear favicon urls database when history is cleared [Triage Comment] Mobile only - approved for Aurora.