Clear favicon urls database when history is cleared

RESOLVED FIXED in Firefox 11

Status

()

Firefox for Android
General
P3
normal
RESOLVED FIXED
6 years ago
10 months ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

unspecified
Firefox 12
All
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, firefox12 fixed, fennec11+)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
We have a separate database that holds favicons urls that should be cleared when user clears its browsing history data.
(Assignee)

Updated

6 years ago
OS: Linux → Android
Hardware: x86 → All

Updated

6 years ago
Assignee: nobody → lucasr.at.mozilla
Priority: -- → P3
(Assignee)

Comment 1

6 years ago
Created attachment 573269 [details] [diff] [review]
Clear favicon urls database when history is cleared
Attachment #573269 - Flags: review?(blassey.bugs)
Attachment #573269 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 2

6 years ago
Pushed: http://hg.mozilla.org/projects/birch/rev/0677f937cf3b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
These patches were backed while investigating Talos failures.  Now that tests are green again, we will need to reland.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
backout was backed out https://hg.mozilla.org/projects/birch/rev/6f925b45a547
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Where are the tests for this?
Question: should all favicons icons be cleared?  What about the default bookmarks and search engines?
(Assignee)

Comment 7

6 years ago
(In reply to Damon Sicore (:damons) from comment #5)
> Where are the tests for this?

Damon, we don't have a unit test infra in place to start adding tests yet. I'd suggest to file a bug to add the infra for tests on native UI and set a high priority for it.
(Assignee)

Comment 8

6 years ago
(In reply to Naoki Hirata :nhirata from comment #6)
> Question: should all favicons icons be cleared?  What about the default
> bookmarks and search engines?

The favicon images won't be removed for bookmarks because their entries in the database are kept. This means that the favicons should still be visible in the bookmarks tab even after history is cleared.

What will happen though is that the favicon URLs for the bookmarks will be cleared. So when they are accessed for the first time after history was cleared, the favicon will be downloaded again even though the image is still present in the database (which is not a big deal).
20111114041052
http://hg.mozilla.org/projects/birch/rev/859ecdfe0168
Samsung Galaxy SII (Android 2.3.4)
Status: RESOLVED → VERIFIED
This patch was reverted in birch as part of the backout, but never got put back because the commits following the backout-of-the-backout used a different changeset as parent. The code is NOT in m-c now and the patch should be re-landed.
Reopening, see my previous comment.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
tracking-fennec: --- → 11+
(Assignee)

Comment 12

5 years ago
Relanded:
http://hg.mozilla.org/integration/mozilla-inbound/rev/23099bd5d462
(Assignee)

Comment 13

5 years ago
Comment on attachment 573269 [details] [diff] [review]
Clear favicon urls database when history is cleared

This patch clears data that is supposed to be removed when history is cleared.
Attachment #573269 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/23099bd5d462
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment on attachment 573269 [details] [diff] [review]
Clear favicon urls database when history is cleared

[Triage Comment]
Mobile only - approved for Aurora.
Attachment #573269 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/a4c0f729f35e
status-firefox11: --- → fixed
status-firefox12: --- → fixed
You need to log in before you can comment on or make changes to this bug.