Don't create runnables for setting the title on unlinked documents

RESOLVED FIXED in mozilla10

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: peterv, Assigned: peterv)

Tracking

Trunk
mozilla10
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 571980 [details] [diff] [review]
v1

When we unlink a title element we unbind it, which tries to change the title of its document. But because we're unlinking, the document might have been unlinked already. Changing the title post a runnable that holds the document. We shouldn't really be touching unlinked documents.
Attachment #571980 - Flags: review?(jst)

Comment 1

6 years ago
Comment on attachment 571980 [details] [diff] [review]
v1


> nsDocument::NotifyPossibleTitleChange(bool aBoundTitleElement)
> {
>+  NS_ASSERTION(!mInUnlinkOrDeletion || !aBoundTitleElement,
>+               "Setting a title while unlinking or destroying the element?");
>+  if (mInUnlinkOrDeletion)
>+    return;
>+
if (expr) {
  stmt;
}
Attachment #571980 - Flags: review?(jst) → review+
(Assignee)

Comment 2

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8041a57029dc
Target Milestone: --- → mozilla10

Comment 3

6 years ago
https://hg.mozilla.org/mozilla-central/rev/8041a57029dc
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Blocks: 701342
You need to log in before you can comment on or make changes to this bug.