699812 - Cannot search for groups

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect, P2)

Description

[Josh Matthews [:jdm]]

If I want to add more groups to my profile, but would feel silly adding groups for which I am the only member, there's no logical place for me to search for groups right now. The search box text talks about searching names and nicks, and the URL for a group membership view is not easily modifiable (since it's ###-groupname, where ### is not something I know for a given group). I'm reduced to adding groups to my profile, checking the membership, then removing them if I'm the only member.

Comment 1

[Luke Crouch [:groovecoder]]

+1 adding group search. I just had a contributor ask to get involved with popcorn.js and I want to search for "popcorn" group so I know to whom I should send this contributor.

Comment 2

[Aakash Desai [:aakashd]]

I'm going to let bug 700766 consume this bug. It's a good implementation and worth going toward.

Comment 3

[Josh Matthews [:jdm]]

Could this bug be repurposed to making groups searchable? I think that's a really important feature, and if it exists and I'm missing it, then some better labelling should be considered.

Comment 4

[Aakash Desai [:aakashd]]

Before I go any further, I just want to get some clarity: are you referring to showing groups as search results?

Comment 5

[Josh Matthews [:jdm]]

That would be a really easy way of addressing it, yes. Consider if I want to find a member of the Javascript team, and I know they're tagged as spidermonkey. Currently I need to find a member of the group to get access to the tag, which is tautological.

Comment 6

[Aakash Desai [:aakashd]]

Right, we actually support searching by groups. The issue that you're seeing here is that no one from the popcorn.js team has grouped themselves (or created accounts on Mozillians.org).

Another issue is how to deal with similar searches made around group names such as "popcorn" instead of "popcorn.js". I'll re-open, but I believe there's a bug on file for something like this.

Comment 7

[Josh Matthews [:jdm]]

There's no visual cue from the search box that groups will be searched - it just says "Name, IRC Nick, or Email".

Comment 8

[Aakash Desai [:aakashd]]

We can add that in there.

Comment 9

[Luke Crouch [:groovecoder]]

And additional UI improvement, when I search for "popcorn" or "popcorn.js" it says "The Mozillian you are looking for is not in the directory. Please check your spelling or invite this person to create a profile."

The message should be a little more generic if it's searching for tags as well.

Comment 10

[Aakash Desai [:aakashd]]

(In reply to Luke Crouch [:groovecoder] from comment #9)
> And additional UI improvement, when I search for "popcorn" or "popcorn.js"
> it says "The Mozillian you are looking for is not in the directory. Please
> check your spelling or invite this person to create a profile."
> 
> The message should be a little more generic if it's searching for tags as
> well.

Good idea. So, this bug is going to be about two things:

1. Add "Groups" to the search field alt text.
2. Better the search results error page content a whole lot better.

We're bettering the overall functionality with groups in the app in other bugs and are listed in 1.2.

Comment 11

[Aakash Desai [:aakashd]]

This bug missed the string freeze. Moving back to 1.3.

Comment 12

[Aakash Desai [:aakashd]]

Bram's got a good hold on how to deal with this in the new search results UX.

Comment 13

[Bram Pitoyo [:bram]]

See attachment 610454 [details].

Comment 14

[Aakash Desai [:aakashd]]

r? https://github.com/mozilla/mozillians/pull/285

Comment 15

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/8ee2e593d0996a4b2abea6cc5fa0af4c918a18dc
[fix bug 699812] Groups shown in search results

fix break in search text

whitespace fix

https://github.com/mozilla/mozillians/commit/6f7e81e81357bd223731e1a3ae201bf096ff536f
Merge pull request #290 from sammybahamas/groupsearch

[fix bug 699812] Groups shown in search results

Comment 16

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

QA verified on stage --

Search terms such as return expected results - note qa hasn't extensively verified search (there are known problems):
- qa
- al
- beard
- *
- u