699927 - Update the Windows RDF for the Flash Player 11.1.102.55 Update

Status: RESOLVED FIXED

(Toolkit Graveyard :: Plugin Finder Service, defect)

Description

[John Pfeiffer]

User Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.23) Gecko/20110920 Firefox/3.6.9
Build ID: 20110920075126

Steps to reproduce:

Update the Windows RDF for the Flash Player 11.1.102.55 Update.


Actual results:

Flash Player 11.1.102.55 will be released on Thursday 11/10/2011 at 10am PST. Please update the PFS RDF for Windows at that time. Here are the RDF configuration changes (note we now have both 32-bit and 64-bit installers):



Expected results:

RDF changes for 32-bit Windows systems:

<pfs:version>11.1.102.55</pfs:version>
<pfs:InstallerLocation>http://download.macromedia.com/pub/flashplayer/current/FP_PL_PFS_INSTALLER_32bit.exe</pfs:InstallerLocation>
<pfs:InstallerHash>sha256:de413e759589b387bfa17852a91e752e0318104998e0e4bbddacd9972483ec12</pfs:InstallerHash>

RDF change for 64-bit Windows systems:

<pfs:version>11.1.102.55</pfs:version>
<pfs:InstallerLocation>http://download.macromedia.com/pub/flashplayer/current/FP_PL_PFS_INSTALLER_64bit.exe</pfs:InstallerLocation>
<pfs:InstallerHash>sha256:c31e5238b00b284e64969262161fd170a3288e34d3ddcc95b50b558de7a74744</pfs:InstallerHash>

Comment 2

[Carsten Book [:Tomcat]]

Attachment: patch 32bit

taking this bug and created a patch (please bear with me its my first patch :))

Comment 3

[Kev Needham [:kev]]

Attachment: Updated PFS to suppoert 32/64-bit Flash Player

From Comment #0, both the 32 and 64-bit installers are now supported. This patch adds support for offering the 64-bit Flash Player to 64-bit Firefox builds as well as updating the version to the latest version of Flash.

Tomcat has tested this version and it appears to function as expected. The new version can also be tested by setting the pfs.datasource.url pref to "http://kev.deadsquid.com/whafa/pfs.php?mimetype=%PLUGIN_MIMETYPE%&appID=%APP_ID%&appVersion=%APP_VERSION%&clientOS=%CLIENT_OS%&chromeLocale=%CHROME_LOCALE%&appRelease=%APP_RELEASE%"

Ready to apply and push.

Comment 4

[Carsten Book [:Tomcat]]

(In reply to Kev [:kev] Needham from comment #3)
> Tomcat has tested this version and it appears to function as expected. The
> new version can also be tested by setting the pfs.datasource.url pref to
> "http://kev.deadsquid.com/whafa/pfs.
> php?mimetype=%PLUGIN_MIMETYPE%&appID=%APP_ID%&appVersion=%APP_VERSION%&client
> OS=%CLIENT_OS%&chromeLocale=%CHROME_LOCALE%&appRelease=%APP_RELEASE%"
> 


confirmed, testing worked well and passed the test on 64bit and 32bit - both flash versions were working

Comment 5

[Carsten Book [:Tomcat]]

ping, this seems to be waiting for review

Comment 6

[Michael Morgan [:morgamic]]

Comment on attachment 574303 [details] [diff] [review]
Updated PFS to suppoert 32/64-bit Flash Player

Sorry guys, fell behind.  Indentation seems weird but otherwise is fine.  Any chance you could strip tabs?

Comment 7

[Kev Needham [:kev]]

Attachment: edits with tabbed stripped per comment #6

Comment 8

[Kev Needham [:kev]]

Attachment: edits with tabbed stripped per comment #6

Let's try that again with vars defined properly.

Tabs stripped, indents no longer wonky, this should be gtg now.

Wil, can you push this version of the patch?

Comment 9

[Wil Clouser [:clouserw]]

Done in r98315.  Will go live today at 2.

Comment 10

[Kev Needham [:kev]]

Thanks, Wil. Much appreciated, all.

Comment 11

[Carsten Book [:Tomcat]]

uhm seems we used the old version number here

Comment 12

[Carsten Book [:Tomcat]]

Attachment: patch to correct the version number

Comment 13

[Matthias Versen [:Matti]]

Tomcat: Is this still relevant ?

Comment 14

[Carsten Book [:Tomcat]]

(In reply to Matthias Versen (Matti) from comment #13)
> Tomcat: Is this still relevant ?

no, already superseded by new versions, thanks!

Comment 15

[Kev Needham [:kev]]

Comment on attachment 594121 [details] [diff] [review]
patch to correct the version number

Closing this off, as it's long been implemented