699942 - Yes->Yes, I want to help

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[(dormant account)]

Hopefully this will make opting into telemetry slightly more obvious

Comment 1

[(dormant account)]

Attachment: yes

Comment 2

[Sid Stamm [:geekboy or :sstamm]]

Comment on attachment 572099 [details] [diff] [review]
yes

Review of attachment 572099 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine.

Comment 3

[(dormant account)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/ffdc872d5450

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 572099 [details] [diff] [review]
yes

You need to change the string name when you change its semantics.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

backed out on inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/7d8117fd5e8e

Comment 6

[(dormant account)]

Pushed corrected patch to inbound

http://hg.mozilla.org/integration/mozilla-inbound/rev/45c63bb1d7df

Comment 7

[(dormant account)]

Backed out http://hg.mozilla.org/integration/mozilla-inbound/rev/9df272a366e2

Pushed again http://hg.mozilla.org/integration/mozilla-inbound/rev/8b6b59955d33

Comment 8

[Ed Morley [:emorley]]

I'm not going to paste the the rest of the merged backout-dance, but here's the final cset :-)

https://hg.mozilla.org/mozilla-central/rev/8b6b59955d33