Closed
Bug 699942
Opened 13 years ago
Closed 13 years ago
Yes->Yes, I want to help
Categories
(Toolkit :: Telemetry, defect)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: taras.mozilla, Assigned: taras.mozilla)
Details
(Whiteboard: [inbound])
Attachments
(1 file)
|
839 bytes,
patch
|
geekboy
:
review+
Gavin
:
review-
|
Details | Diff | Splinter Review |
Hopefully this will make opting into telemetry slightly more obvious
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #572099 -
Flags: review?(sstamm)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 572099 [details] [diff] [review]
yes
Review of attachment 572099 [details] [diff] [review]:
-----------------------------------------------------------------
Looks fine.
Attachment #572099 -
Flags: review?(sstamm) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Whiteboard: [inbound]
|
||
Comment 4•13 years ago
|
||
Comment on attachment 572099 [details] [diff] [review]
yes
You need to change the string name when you change its semantics.
Attachment #572099 -
Flags: review-
|
|
||
Comment 5•13 years ago
|
||
backed out on inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/7d8117fd5e8e
Assignee: nobody → tglek
Whiteboard: [inbound]
|
|
Assignee | |
Comment 6•13 years ago
|
||
Pushed corrected patch to inbound
http://hg.mozilla.org/integration/mozilla-inbound/rev/45c63bb1d7df
Whiteboard: [inbound]
|
|
Assignee | |
Comment 7•13 years ago
|
||
|
||
Comment 8•13 years ago
|
||
I'm not going to paste the the rest of the merged backout-dance, but here's the final cset :-)
https://hg.mozilla.org/mozilla-central/rev/8b6b59955d33
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
OS: Windows 7 → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Version: unspecified → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•