700006 - [layers] about:home show dead space

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: screenshot

Breaking this out of bug 700005

The about:home page has dead space at the bottom. See screenshot

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: patch

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 572681 [details] [diff] [review]
patch

Review of attachment 572681 [details] [diff] [review]:
-----------------------------------------------------------------

::: embedding/android/GeckoApp.java
@@ +830,5 @@
> +                int layoutWidth = mGeckoLayout.getMeasuredWidth();
> +                int layoutHeight = mGeckoLayout.getMeasuredHeight();
> +                // increase page size if smaller than layout dimensions
> +                if (size.width < layoutWidth || size.height < layoutHeight) {
> +                    size = new IntSize(Math.max(size.width, layoutWidth), Math.max(size.height, layoutHeight));

does it make sense to line wrap this?

Comment 4

[Doug Turner (:dougt)]

[Thu Nov 10 20:43:10 dougt@dougt:~/builds/birch ] $ hg qpush
applying attachment.cgi?id=572681
patching file embedding/android/GeckoApp.java
Hunk #1 FAILED at 820
1 out of 1 hunks FAILED -- saving rejects to file embedding/android/GeckoApp.java.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir

Comment 5

[Kartikaya Gupta (email:[e-mail])]

http://hg.mozilla.org/projects/birch/rev/772155060499

Comment 7

[Catalin Suciu [:csuciu]]

Verified fixed on Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111116
Firefox/11.0a1 Fennec/11.0a1