[layers] about:home show dead space

VERIFIED FIXED

Status

()

Firefox for Android
General
P1
normal
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: mfinkle, Unassigned)

Tracking

unspecified
x86
Linux
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(2 attachments)

Created attachment 572166 [details]
screenshot

Breaking this out of bug 700005

The about:home page has dead space at the bottom. See screenshot
(Reporter)

Updated

6 years ago
Priority: -- → P1
Created attachment 572681 [details] [diff] [review]
patch
Attachment #572681 - Flags: review?(doug.turner)

Comment 2

6 years ago
Comment on attachment 572681 [details] [diff] [review]
patch

Review of attachment 572681 [details] [diff] [review]:
-----------------------------------------------------------------

::: embedding/android/GeckoApp.java
@@ +830,5 @@
> +                int layoutWidth = mGeckoLayout.getMeasuredWidth();
> +                int layoutHeight = mGeckoLayout.getMeasuredHeight();
> +                // increase page size if smaller than layout dimensions
> +                if (size.width < layoutWidth || size.height < layoutHeight) {
> +                    size = new IntSize(Math.max(size.width, layoutWidth), Math.max(size.height, layoutHeight));

does it make sense to line wrap this?
Attachment #572681 - Flags: review?(doug.turner) → review+
(Reporter)

Updated

6 years ago
Duplicate of this bug: 701408

Comment 4

6 years ago
[Thu Nov 10 20:43:10 dougt@dougt:~/builds/birch ] $ hg qpush
applying attachment.cgi?id=572681
patching file embedding/android/GeckoApp.java
Hunk #1 FAILED at 820
1 out of 1 hunks FAILED -- saving rejects to file embedding/android/GeckoApp.java.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
http://hg.mozilla.org/projects/birch/rev/772155060499
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Duplicate of this bug: 701793
Verified fixed on Mozilla/5.0 (Android;Linux armv7l;rv:11.0a1)Gecko/20111116
Firefox/11.0a1 Fennec/11.0a1
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.