70008 - gtk embedding widget broken. Galeon, Nautilus, gtkEmbed all fail.

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Philip Langdale]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.4.2-ac1 i686; en-US; 0.9) Gecko/20010223
BuildID:    2001022222

One of the updates on 22/02 or 21/02 seems to have broken gtk embedding. Now
neither galeon, nautilus or gtkembed will run. galeon
and nautilus seg fault out when ( it appears ) they try to display
the embedded widget. gtkembed exits silently.
Actually creation of the widget and mozilla initialisation seems to work. 

Reproducible: Always
Steps to Reproduce:
run galeon, nautilus or gtkembed with mozilla newer than 20010221

Actual Results:  Galeon and Nautilus segfault and gtkembed silently exits.

Expected Results:  Programs should have successfully started up.

This is with nautilus 0.8 and galeon from cvs. Both versions
worked fine with 20010221 mozilla. I build mozilla from cvs.

Comment 1

[Christopher Blizzard (:blizzard)]

Yeah, the embedding widget is pretty borked.  I'm getting some fun assertions:

###!!! ASSERTION: re-entrant call to service manager created service twice!: '!m
Services->Get(&key)', file ../../../mozilla/xpcom/components/nsServiceManager.cp
p, line 353
###!!! Break: at file ../../../mozilla/xpcom/components/nsServiceManager.cpp, li
ne 353

###!!! ASSERTION: GetMainWidget coughed up a null widget: 'Error', file ../../..
/mozilla/docshell/base/nsDocShell.cpp, line 2928
###!!! Break: at file ../../../mozilla/docshell/base/nsDocShell.cpp, line 2928
###!!! ASSERTION: NS_ENSURE_TRUE(NS_SUCCEEDED(nsDocShell::SetupNewViewer(aViewer
))) failed: '(!((nsDocShell::SetupNewViewer(aViewer)) & 0x80000000))', file ../.
./../mozilla/docshell/base/nsWebShell.cpp, line 350
###!!! Break: at file ../../../mozilla/docshell/base/nsWebShell.cpp, line 350
net_state_change_cb 196612

Comment 2

[Christopher Blizzard (:blizzard)]

My first guess is that it's danm's changes.  Danm?

Comment 3

[Philip Langdale]

I have just tried a fresh build from this morning's cvs and gtkEmbed is
working once again but galeon and nautilus are still broken.

danm's last checkin on embedding was on the 16th but the breakage didn't appear
until the 22nd. Possibly due to a combined effect with one of the embedding
checkins on the 21st or 22nd?

Comment 4

[Jim Bray]

  This is the Galeon bug report:

http://bugzilla.gnome.org/show_bug.cgi?id=51325

#0  0x40595b12 in GtkMozEmbedChrome::GetPrimaryContentShell ()
   from /usr/local/mozilla/libgtkembedmoz.so
#1  0x40597e8e in GtkMozEmbedPrivate::OnChromeStateChange ()
   from /usr/local/mozilla/libgtkembedmoz.so
#2  0x4059c1a8 in GtkMozEmbedChromeProgress::OnStateChange ()
   from /usr/local/mozilla/libgtkembedmoz.so

Comment 5

[Philip Langdale]

Hope I'm not jumping the gun here, but gtkmozembed2 is now building by default
in cvs and it fixes the problem ( as well as adding gtk message dialogs :-) 
The old gtkmozembed code is still broken but no longer builds.