70014 - DOM1 unable to get chOff attribute

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jan Carpenter]

Overview Description: 
chOff attribute can be accessed by using something like "...attributes[2]"; 
however it can't be found by just using chOff unless you specifically set it 
through DOM.

Steps to Reproduce: 
- see attached testcase

Actual Results: 
DOM see's nothing when looking at the chOff attribute

Expected Results: 
in this testcase, it should see 25

Build Date & Platform Bug Found: 
2001-02-18-10-Mtrunk

Additional Builds and Platforms Tested On: 
(other platforms unavailable to test currently...)

Additional Information:

Comment 1

[Jan Carpenter]

Attachment: attaching testcase

Comment 2

[Johnny Stenback (:jst)]

This change fixes this problem, mis-spelled charoff in the atoms list.

Index: html/base/src/nsHTMLAtomList.h
===================================================================
RCS file: /cvsroot/mozilla/content/html/base/src/nsHTMLAtomList.h,v
retrieving revision 3.24
diff -u -r3.24 nsHTMLAtomList.h
--- nsHTMLAtomList.h    2001/02/15 13:22:20     3.24
+++ nsHTMLAtomList.h    2001/02/28 00:00:53
@@ -84,7 +84,7 @@
 HTML_ATOM(charoff, "charoff")
 HTML_ATOM(charset, "charset")
 HTML_ATOM(checked, "checked")
-HTML_ATOM(choff, "choff")
+HTML_ATOM(choff, "charoff")
 HTML_ATOM(cite, "cite")
 HTML_ATOM(kClass, "class")
 HTML_ATOM(classid, "classid")

Comment 3

[Johnny Stenback (:jst)]

Heikki sez r=heikki

Comment 4

[Johnny Stenback (:jst)]

Attachment: Better fix.

Comment 5

[Heikki Toivonen (remove -bugzilla when emailing directly)]

The latter fix looks better to me too (why did I not notice the dupe when it was
right there in the diff ;). I am just wondering why did DOM choose choff when it
accesses the charoff attribute... Anyway, r=heikki.

Comment 6

[Johnny Stenback (:jst)]

My guess is that the DOM chose choff cause that's what IE implemented at the
time, why I don't know. Thanks for the review, Vidur sez sr=vidur.

Comment 7

[Johnny Stenback (:jst)]

Fix checked in.

Comment 8

[Prashant Desale]

QA contact Update

Comment 9

[Prashant Desale]

Updating QA contact to Shivakiran Tummala.

Comment 10

[Sivakiran Tummala]

verified on build 2001-06-21-11.0.9.1 windows 2000 ..marking as verified