700179 - [Skia] Crash in GetSourceSurfaceForSurface on windows

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Stack is:

 0  xul.dll!gfxPlatform::GetSourceSurfaceForSurface(mozilla::gfx::DrawTarget *,gfxASurface *) [gfxPlatform.cpp:8c1234d5877e : 506 + 0x0]
    eip = 0x017b994f   esp = 0x0012c0a4   ebp = 0x0012c0d8   ebx = 0x0655d400
    esi = 0x00000000   edi = 0x0d2fbfa0   eax = 0x00000000   ecx = 0x10454eb0
    edx = 0x00ab0040   efl = 0x00210246
    Found by: given as instruction pointer in context
 1  xul.dll!nsCanvasRenderingContext2DAzure::DrawImage(nsIDOMElement *,float,float,float,float,float,float,float,float,unsigned char) [nsCanvasRenderingContext2DAzure.cpp:8c1234d5877e : 3664 + 0x14]
    eip = 0x01251b21   esp = 0x0012c0e0   ebp = 0x0012c168
    Found by: call frame info
 2  xul.dll!nsIDOMCanvasRenderingContext2D_DrawImage [dom_quickstubs.cpp:8c1234d5877e : 2772 + 0x62]
    eip = 0x0150565c   esp = 0x0012c1bc   ebp = 0x0012c26c   ebx = 0x06479040
    Found by: call frame info

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Add GetSize() support for the windows surfaces

I believe this is because the GetSize() call here is returning { -1, -1}.

It would be interesting to know why GetAsImageSurface is failing for these surfaces though. I don't know enough about the windows cairo backend to tell from looking at the source.

Comment 2

[Marco Castelluccio [:marco]]

You were right, the path of the crash is the if (!imgSurface) {, gfx\thebes\gfxPlatform.cpp, line 474

Comment 3

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/36b377464b44

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/36b377464b44