700190 - Fix test_aboutmemory.xul

Status: RESOLVED FIXED

(Toolkit :: about:memory, defect)

Description

[Nicholas Nethercote [inactive]]

Attachment: patch

When I run test_aboutmemory.xul I get this output on the console:

TEST-INFO | unknown test url | [SimpleTest/SimpleTest.js, window.onerror] An error occurred: actual.QueryInterface is not a function at chrome://mochitests/content/chrome/toolkit/components/aboutmemory/tests/chrome/test_aboutmemory.xul:370
JavaScript error: chrome://mochitests/content/chrome/toolkit/components/aboutmemory/tests/chrome/test_aboutmemory.xul, line 370: actual.QueryInterface is not a function

AFAICT the problem was introduced by bug 674290 -- the use of a validator function as the first argument of waitForClipboard() is wrong.  I confirmed (with the current tip) that changing the expected output string does not cause the test to fail as it should, and only 1 thing is checked instead of the expected 3.  Either this was broken from the start, or maybe waitForClipboard() changed?

Either way, the attached patch fixes things.

Comment 1

[Justin Lebar (not reading bugmail)]

I think waitForClipboard changed.  Which is good, because it was silly to make code QI like this.  But it's bad that the test harness didn't catch this failure.

I guess the reason that this failure didn't cause the tree to burn is that the exception was inside checkClipboard?  If we throw an exception outside checkClipboard, does the test fail?

r=me if exceptions in general cause this test to fail.  Otherwise, we need a bigger hammer.

Comment 2

[Nicholas Nethercote [inactive]]

I inserted |throw("foobar")| at the top-level of the JS code and this shows up in the console:

  TEST-INFO | unknown test url | [SimpleTest/SimpleTest.js, window.onerror] An error occurred: uncaught exception: foobar at :0

but the test still passes.  I could wrap everything in the try-block but it seems like the test framework should catch this.

Comment 3

[Nicholas Nethercote [inactive]]

bz tells me that chrome tests swallow uncaught exceptions.  See bug 652494.

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b642565bfad

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/2b642565bfad