700203 - Pymake needs to survive native commands doing sys.exit(0)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/rev/10388675f775

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/432d201b7606

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/432d201b7606

Comment 5

[(not currently active) Ted Mielczarek]

Comment on attachment 572374 [details] [diff] [review]
Patch

Review of attachment 572374 [details] [diff] [review]:
-----------------------------------------------------------------

::: pymake/process.py
@@ +215,5 @@
>              print >>sys.stderr, e
>              return e.exitcode
>          except:
> +            e = sys.exc_info()[1]
> +            if isinstance(e, SystemExit) and e.code == '0':

This doesn't make sense to me. From the Python docs:
http://docs.python.org/library/exceptions.html#exceptions.SystemExit

Is someone actually calling sys.exit('0')? That really should cause the Python interpreter to exit with an error! We should fix the caller in that case, and just check for e.code == 0 or e.code is None here.

::: tests/pycmd.py
@@ +8,5 @@
>    with open(args[0], 'w') as f:
>      f.write(os.environ[args[1]])
> +
> +def asplode(args):
> +  sys.exit(args[0])

This probably wants to be int(args[0]), no?

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch

Aha!

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 572434 [details] [diff] [review]
Patch

Review of attachment 572434 [details] [diff] [review]:
-----------------------------------------------------------------

::: pymake/process.py
@@ +215,5 @@
>              print >>sys.stderr, e
>              return e.exitcode
>          except:
> +            e = sys.exc_info()[1]
> +            if isinstance(e, SystemExit) and e.code == 0:

I think according to that link I pasted before, this wants to be "e.code == 0 or e.code is None".