700218 - Unclosed Cursor detected assertions when running Fennec Native

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[Doug Turner (:dougt)]

11-06 19:59:08.032 28749 28750 W Cursor  : Unclosed Cursor detected
11-06 19:59:08.032 28749 28750 W Cursor  :      at android.content.ContentResolver.query(ContentResolver.java:258)
11-06 19:59:08.032 28749 28750 W Cursor  :      at org.mozilla.gecko.Tab$CheckBookmarkTask.doInBackground(Tab.java:323)
11-06 19:59:08.032 28749 28750 W Cursor  :      at org.mozilla.gecko.Tab$CheckBookmarkTask.doInBackground(Tab.java:319)
11-06 19:59:08.032 28749 28750 W Cursor  :      at android.os.AsyncTask$2.call(AsyncTask.java:185)
11-06 19:59:08.032 28749 28750 W Cursor  :      at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
11-06 19:59:08.032 28749 28750 W Cursor  :      at java.util.concurrent.FutureTask.run(FutureTask.java:137)
11-06 19:59:08.032 28749 28750 W Cursor  :      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1068)
11-06 19:59:08.032 28749 28750 W Cursor  :      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:561)
11-06 19:59:08.032 28749 28750 W Cursor  :      at java.lang.Thread.run(Thread.java:1096)
11-06 19:59:08.040 28749 28750 W Cursor  : Unclosed Cursor detected
11-06 19:59:08.040 28749 28750 W Cursor  :      at android.content.ContentResolver.query(ContentResolver.java:258)
11-06 19:59:08.040 28749 28750 W Cursor  :      at org.mozilla.gecko.GlobalHistory$1.run(GlobalHistory.java:82)
11-06 19:59:08.040 28749 28750 W Cursor  :      at android.os.Handler.handleCallback(Handler.java:587)
11-06 19:59:08.040 28749 28750 W Cursor  :      at android.os.Handler.dispatchMessage(Handler.java:92)
11-06 19:59:08.040 28749 28750 W Cursor  :      at android.os.Looper.loop(Looper.java:143)
11-06 19:59:08.040 28749 28750 W Cursor  :      at org.mozilla.gecko.GeckoAppShell$LooperThread.run(GeckoAppShell.java:146)
11-06 19:59:08.040 28749 28756 E Fennec  : ### Texture upload rect height is 32
11-06 19:59:08.048 28749 28750 W Cursor  : Unclosed Cursor detected
11-06 19:59:08.048 28749 28750 W Cursor  :      at android.content.ContentResolver.query(ContentResolver.java:258)
11-06 19:59:08.048 28749 28750 W Cursor  :      at org.mozilla.gecko.Tab$CheckBookmarkTask.doInBackground(Tab.java:323)
11-06 19:59:08.048 28749 28750 W Cursor  :      at org.mozilla.gecko.Tab$CheckBookmarkTask.doInBackground(Tab.java:319)
11-06 19:59:08.048 28749 28750 W Cursor  :      at android.os.AsyncTask$2.call(AsyncTask.java:185)
11-06 19:59:08.048 28749 28750 W Cursor  :      at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
11-06 19:59:08.056 28749 28750 W Cursor  :      at java.util.concurrent.FutureTask.run(FutureTask.java:137)
11-06 19:59:08.056 28749 28750 W Cursor  :      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1068)
11-06 19:59:08.056 28749 28750 W Cursor  :      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:561)
11-06 19:59:08.056 28749 28750 W Cursor  :      at java.lang.Thread.run(Thread.java:1096)

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/projects/birch/rev/1960c3eeb869

Comment 3

[Wesley Johnston (:wesj)]

These patches were backed while investigating Talos failures.  Now that tests are green again, we will need to reland.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

relanded https://hg.mozilla.org/projects/birch/rev/61b90e68869a

Comment 5

[Kartikaya Gupta (email:[e-mail]) (away until Feb-2020)]

Happening again on latest birch (rev 9999a423d8ab)

11-18 10:07:49.271  9038  9039 E Cursor  : Finalizing a Cursor that has not been deactivated or closed. database = /data/data/org.mozilla.fennec_kats/databases/favicon_urls.db, table = favicon_urls, query = SELECT favicon_url FROM favicon_urls WHERE (page_url = ?)
11-18 10:07:49.271  9038  9039 E Cursor  : android.database.sqlite.DatabaseObjectNotClosedException: Application did not close the cursor or database object that was opened here
11-18 10:07:49.271  9038  9039 E Cursor  : 	at android.database.sqlite.SQLiteCursor.<init>(SQLiteCursor.java:210)
11-18 10:07:49.271  9038  9039 E Cursor  : 	at android.database.sqlite.SQLiteDirectCursorDriver.query(SQLiteDirectCursorDriver.java:53)
11-18 10:07:49.271  9038  9039 E Cursor  : 	at android.database.sqlite.SQLiteDatabase.rawQueryWithFactory(SQLiteDatabase.java:1350)
11-18 10:07:49.271  9038  9039 E Cursor  : 	at android.database.sqlite.SQLiteQueryBuilder.query(SQLiteQueryBuilder.java:330)
11-18 10:07:49.271  9038  9039 E Cursor  : 	at android.database.sqlite.SQLiteQueryBuilder.query(SQLiteQueryBuilder.java:280)
11-18 10:07:49.271  9038  9039 E Cursor  : 	at org.mozilla.gecko.Favicons$DatabaseHelper.getFaviconUrlForPageUrl(Favicons.java:128)
11-18 10:07:49.271  9038  9039 E Cursor  : 	at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:371)
11-18 10:07:49.271  9038  9039 E Cursor  : 	at org.mozilla.gecko.Favicons$LoadFaviconTask.doInBackground(Favicons.java:215)
11-18 10:07:49.271  9038  9039 E Cursor  : 	at android.os.AsyncTask$2.call(AsyncTask.java:185)
11-18 10:07:49.271  9038  9039 E Cursor  : 	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
11-18 10:07:49.271  9038  9039 E Cursor  : 	at java.util.concurrent.FutureTask.run(FutureTask.java:137)
11-18 10:07:49.271  9038  9039 E Cursor  : 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1068)
11-18 10:07:49.271  9038  9039 E Cursor  : 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:561)
11-18 10:07:49.271  9038  9039 E Cursor  : 	at java.lang.Thread.run(Thread.java:1096)

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

Kats, please file a new bug