Closed
Bug 700314
Opened 14 years ago
Closed 14 years ago
Remove nsNavHistory nsICharsetResolver implementation
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: mak, Assigned: mak)
Details
(Keywords: addon-compat)
Attachments
(1 file)
|
4.72 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
nsNavHistory implements nsICharsetResolver, but nothing in the codebase is using it, so we may remove it.
Cc-ing bz in case I'm missing something at the content level, but looks really unused.
|
Assignee | |
Updated•14 years ago
|
Keywords: addon-compat
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → mak77
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #572475 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 2•14 years ago
|
||
Comment on attachment 572475 [details] [diff] [review]
patch v1.0
me fail. retrying.
Attachment #572475 -
Attachment is obsolete: true
Attachment #572475 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Comment 3•14 years ago
|
||
Comment on attachment 572475 [details] [diff] [review]
patch v1.0
hm, nope it was right :( sorry.
Attachment #572475 -
Attachment is obsolete: false
Attachment #572475 -
Flags: review?(bzbarsky)
|
||
Comment 4•14 years ago
|
||
Comment on attachment 572475 [details] [diff] [review]
patch v1.0
Yeah, this went away in bug 582712. Good catch!
Attachment #572475 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Flags: in-testsuite-
|
||
Comment 6•14 years ago
|
||
This means we can get rid of nsICharsetResolver entirely, doesn't it? Followup bug?
|
|
||
Comment 7•14 years ago
|
||
I filed bug 700490.
|
|
||
Comment 8•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•