Closed Bug 700314 Opened 13 years ago Closed 13 years ago

Remove nsNavHistory nsICharsetResolver implementation

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla10

People

(Reporter: mak, Assigned: mak)

Details

(Keywords: addon-compat)

Attachments

(1 file)

patch v1.0
4.72 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
nsNavHistory implements nsICharsetResolver, but nothing in the codebase is using it, so we may remove it.

Cc-ing bz in case I'm missing something at the content level, but looks really unused.
Keywords: addon-compat
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attached patch patch v1.0 — — Splinter Review 

        Attachment #572475 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 572475 [details] [diff] [review]
patch v1.0

me fail. retrying.

        Attachment #572475 -
        Attachment is obsolete: true

        Attachment #572475 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 572475 [details] [diff] [review]
patch v1.0

hm, nope it was right :( sorry.

        Attachment #572475 -
        Attachment is obsolete: false

        Attachment #572475 -
        Flags: review?(bzbarsky)

    
    

    
  
Comment on attachment 572475 [details] [diff] [review]
patch v1.0

Yeah, this went away in bug 582712.  Good catch!

        Attachment #572475 -
        Flags: review?(bzbarsky) → review+

    
  
Flags: in-testsuite-

    
    

    
  
This means we can get rid of nsICharsetResolver entirely, doesn't it? Followup bug?

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/f7c143137c26
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: