Remove inspectstyle() from the Web Console

RESOLVED FIXED in Firefox 10

Status

()

Firefox
Developer Tools
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: msucan, Assigned: msucan)

Tracking

({verified-beta})

Trunk
Firefox 11
verified-beta
Points:
---

Firefox Tracking Flags

(firefox10+ verified)

Details

([styleinspector][qa+][qa!:10])

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
We now have the Style Inspector in the Inspector/Highlighter feature - we can remove inspectstyle() from the Web Console.
(Assignee)

Comment 1

5 years ago
Created attachment 572548 [details] [diff] [review]
[in-fx-team] proposed patch

Proposed patch.

Please let me know if I forgot something. Thanks!
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
Attachment #572548 - Flags: review?(rcampbell)
(Assignee)

Updated

5 years ago
Whiteboard: [styleinspector]
Comment on attachment 572548 [details] [diff] [review]
[in-fx-team] proposed patch

I think this is good, though a little fuzzy on our rules for l10n changes in aurora. Should be OK, but let's ask Axel if this is something we can do or not.
Attachment #572548 - Flags: review?(rcampbell)
Attachment #572548 - Flags: review?(l10n)
Attachment #572548 - Flags: review+
(Assignee)

Comment 3

5 years ago
Thank you Rob for the r+!

Nominating this bug for Firefox 10 aurora.

Impact: low. This patch removes a Web Console function named inspectstyle(). Users have to know it exists.

Risk: low. This patch simply removes code and should not cause regressions.

Benefits: inspectstyle() opens the Style Inspector in a xul:panel that is generally buggy. Given the Style Inspector is now much more usable from the Inspector/Highlighter feature, we should only allow that usage pattern. This is also less code maintenance for us.

Please let me know if you have further questions/unanswered concerns regarding the patch. Thank you!
tracking-firefox10: --- → ?

Comment 4

5 years ago
Comment on attachment 572548 [details] [diff] [review]
[in-fx-team] proposed patch

Review of attachment 572548 [details] [diff] [review]:
-----------------------------------------------------------------

For Aurora, we just shouldn't land the string removal, and let that cycle through in the next iteration. The strings are already on aurora, so we're not winning a lot by adding noise by removing the post merge.
Attachment #572548 - Flags: review?(l10n) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 574630 [details] [diff] [review]
patch for aurora

Patch for Aurora, without the string removals.

Thanks for the r+ Axel!
Attachment #574630 - Flags: approval-mozilla-aurora?

Comment 6

5 years ago
Comment on attachment 574630 [details] [diff] [review]
patch for aurora

[triage comment]
Approved for aurora. If it had l10n impact, it would not have met the criteria and would have been denied. Please land on aurora asap.
Attachment #574630 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 7

5 years ago
Thank you Christian for your approval!
Whiteboard: [styleinspector] → [styleinspector][land-in-fx-team]
(Assignee)

Comment 8

5 years ago
Comment on attachment 572548 [details] [diff] [review]
[in-fx-team] proposed patch

Pushed to fx-team:

https://hg.mozilla.org/integration/fx-team/rev/2f764f3724d8
Attachment #572548 - Attachment description: proposed patch → [in-fx-team] proposed patch
(Assignee)

Updated

5 years ago
Whiteboard: [styleinspector][land-in-fx-team] → [styleinspector][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/2f764f3724d8
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [styleinspector][fixed-in-fx-team] → [styleinspector]
Target Milestone: --- → Firefox 11

Comment 10

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/c26ec3276c1e
status-firefox10: --- → fixed
Could you please tell me how to test this ?
Sure, simply open the web console and type:
inspectstyle(document.body)

If all is well you should be informed that inspectstyle is not defined.
Based on comment 12, this is verified fixed on Firefox 10 Beta1:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0) Gecko/20100101 Firefox/10.0
Keywords: verified-beta
Whiteboard: [styleinspector] → [styleinspector][qa+][qa!:10]
status-firefox10: fixed → verified

Updated

5 years ago
tracking-firefox10: ? → +
You need to log in before you can comment on or make changes to this bug.