Closed Bug 700331 Opened 13 years ago Closed 13 years ago

Remove inspectstyle() from the Web Console


(DevTools :: General, defect)

Not set


(firefox10+ verified)

Firefox 11
Tracking Status
firefox10 + verified


(Reporter: msucan, Assigned: msucan)


(Keywords: verified-beta, Whiteboard: [styleinspector][qa+][qa!:10])


(2 files)

We now have the Style Inspector in the Inspector/Highlighter feature - we can remove inspectstyle() from the Web Console.
Proposed patch.

Please let me know if I forgot something. Thanks!
Assignee: nobody → mihai.sucan
Attachment #572548 - Flags: review?(rcampbell)
Whiteboard: [styleinspector]
Comment on attachment 572548 [details] [diff] [review]
[in-fx-team] proposed patch

I think this is good, though a little fuzzy on our rules for l10n changes in aurora. Should be OK, but let's ask Axel if this is something we can do or not.
Attachment #572548 - Flags: review?(rcampbell)
Attachment #572548 - Flags: review?(l10n)
Attachment #572548 - Flags: review+
Thank you Rob for the r+!

Nominating this bug for Firefox 10 aurora.

Impact: low. This patch removes a Web Console function named inspectstyle(). Users have to know it exists.

Risk: low. This patch simply removes code and should not cause regressions.

Benefits: inspectstyle() opens the Style Inspector in a xul:panel that is generally buggy. Given the Style Inspector is now much more usable from the Inspector/Highlighter feature, we should only allow that usage pattern. This is also less code maintenance for us.

Please let me know if you have further questions/unanswered concerns regarding the patch. Thank you!
Comment on attachment 572548 [details] [diff] [review]
[in-fx-team] proposed patch

Review of attachment 572548 [details] [diff] [review]:

For Aurora, we just shouldn't land the string removal, and let that cycle through in the next iteration. The strings are already on aurora, so we're not winning a lot by adding noise by removing the post merge.
Attachment #572548 - Flags: review?(l10n) → review+
Attached patch patch for auroraSplinter Review
Patch for Aurora, without the string removals.

Thanks for the r+ Axel!
Attachment #574630 - Flags: approval-mozilla-aurora?
Comment on attachment 574630 [details] [diff] [review]
patch for aurora

[triage comment]
Approved for aurora. If it had l10n impact, it would not have met the criteria and would have been denied. Please land on aurora asap.
Attachment #574630 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Thank you Christian for your approval!
Whiteboard: [styleinspector] → [styleinspector][land-in-fx-team]
Comment on attachment 572548 [details] [diff] [review]
[in-fx-team] proposed patch

Pushed to fx-team:
Attachment #572548 - Attachment description: proposed patch → [in-fx-team] proposed patch
Whiteboard: [styleinspector][land-in-fx-team] → [styleinspector][fixed-in-fx-team]
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [styleinspector][fixed-in-fx-team] → [styleinspector]
Target Milestone: --- → Firefox 11
Could you please tell me how to test this ?
Sure, simply open the web console and type:

If all is well you should be informed that inspectstyle is not defined.
Based on comment 12, this is verified fixed on Firefox 10 Beta1:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:10.0) Gecko/20100101 Firefox/10.0
Keywords: verified-beta
Whiteboard: [styleinspector] → [styleinspector][qa+][qa!:10]
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.