700351 - Fix deep object inspection in the script debugger

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

The script debugger after bug 694538 allows the inspection of objects like 'this', __proto__, etc., albeit only one-level deep. After bug 699419 is done, object inspection should be fixed to work as expected.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: WIP

This is my WIP. Running it on htmlpad.org/debugger I get the following error when I try to inspect the "this" object:

DBG-CLIENT: Error handling response: TypeError: aVar.addProperties is not a function - SF_addExpander([object Object],[object Proxy])@chrome://browser/content/debugger.js:263
([object Proxy])@chrome://browser/content/debugger.js:293
([object Proxy])@resource:///modules/dbg-client.jsm:736
DC_onPacket([object Proxy])@resource:///modules/dbg-client.jsm:370

Commenting out lines 294 and 299 should make the errors disappear, along with deep object inspection.

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 574568 [details] [diff] [review]
WIP

Review of attachment 574568 [details] [diff] [review]:
-----------------------------------------------------------------

You were trying to call addProperties from a property descriptor.

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: WIP fix

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Working patch

Fixed the frame.arguments and __proto__ breakage, as well as a few more corer cases that I've hit: prototypes for wrapped natives and property grips having hasOwnProperty defined. It's just missing a few tests.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Working patch v2

Added tests for making sure expanding an object retrieves its properties, and made a couple of small changes requested in bug 694538 comment 5 and bug 695279 comment 7.

Comment 6

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Working patch v3

Made another simplification requested in bug 694538 comment 8.

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/users/dcamp_campd.org/remote-debug/rev/be56b2aa2541