test_history_expiration.js has a daylight saving time timebomb

RESOLVED FIXED in Firefox 9

Status

()

Toolkit
Downloads API
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: philor, Assigned: mak)

Tracking

({intermittent-failure})

Trunk
mozilla11
intermittent-failure
Points:
---

Firefox Tracking Flags

(firefox9 fixed, firefox10 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Looks like it's during the hour from 23:00 to 24:00, starting last night, and I'd guess continuing for a week, until

let expirableTime = Date.now() - 8 * 24 * 60 * 60 * 1000;

goes back to making a time that's more than 7 days in the past even allowing for the daylight saving time change.

I pushed https://hg.mozilla.org/integration/mozilla-inbound/rev/a62abefaab90 to mozilla-inbound, a few minutes too late to catch this instance so it won't get a chance to take effect until tomorrow night, but I see by https://tbpl.mozilla.org/php/getParsedLog.php?id=7274961&tree=Mozilla-Aurora and friends that it's already on Aurora, and so will be on Beta tomorrow, so even if that's the right thing to do we'll need a bug and flags to land it there.
(Assignee)

Comment 1

6 years ago
Thank you, yes subtracting 8 days is not enough due to the fact expiration uses
strftime('%s','now','localtime','start of day','-7 days','utc')
that also subtracts today

expiration tests do different and that's saving them, not sure why I didn't fix that test the same way :(
http://mxr.mozilla.org/mozilla-central/source/toolkit/components/places/tests/expiration/head_expiration.js#138
Assignee: nobody → mak77
Status: NEW → ASSIGNED
(Assignee)

Comment 2

6 years ago
Created attachment 572761 [details] [diff] [review]
patch v1.0
(Assignee)

Comment 3

6 years ago
Comment on attachment 572761 [details] [diff] [review]
patch v1.0

Supposing this will land after the Aurora uplift, this should be fixed in Aurora and Beta too.

tests-only.
Attachment #572761 - Flags: review?(dietrich)
Attachment #572761 - Flags: approval-mozilla-beta?
Attachment #572761 - Flags: approval-mozilla-aurora?
Attachment #572761 - Flags: review?(dietrich) → review+
(Assignee)

Comment 4

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7810a6b2d52b

Updated

6 years ago
Target Milestone: --- → mozilla11
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/mozilla-central/rev/7810a6b2d52b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 6

6 years ago
Comment on attachment 572761 [details] [diff] [review]
patch v1.0

[triage comment]
Approved for beta and aurora. Please land as soon as possible.
Attachment #572761 - Flags: approval-mozilla-beta?
Attachment #572761 - Flags: approval-mozilla-beta+
Attachment #572761 - Flags: approval-mozilla-aurora?
Attachment #572761 - Flags: approval-mozilla-aurora+

Comment 7

6 years ago
I landed this on aurora:

http://hg.mozilla.org/releases/mozilla-aurora/rev/7f1b098d8fc8

But it din't apply cleanly to beta. Please land on beta.
status-firefox10: --- → fixed
status-firefox9: --- → affected
(Assignee)

Comment 8

6 years ago
yeah for beta the 9 should be changed to a 8, since Aurora had a workaround philor pushed temporily in central the day before the merge.
Will do that.
(Assignee)

Comment 9

6 years ago
https://hg.mozilla.org/releases/mozilla-beta/rev/e31e3efd7e7d
status-firefox9: affected → fixed
Whiteboard: [orange] → [orange][qa-]
Keywords: intermittent-failure
Whiteboard: [orange][qa-] → [qa-]
You need to log in before you can comment on or make changes to this bug.