Last Comment Bug 700591 - test_history_expiration.js has a daylight saving time timebomb
: test_history_expiration.js has a daylight saving time timebomb
: intermittent-failure
Product: Toolkit
Classification: Components
Component: Downloads API (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla11
Assigned To: Marco Bonardo [::mak]
: :Paolo Amadini
Depends on:
Blocks: 438871
  Show dependency treegraph
Reported: 2011-11-08 00:51 PST by Phil Ringnalda (:philor)
Modified: 2012-11-25 19:31 PST (History)
4 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch v1.0 (1.86 KB, patch)
2011-11-08 02:21 PST, Marco Bonardo [::mak]
dietrich: review+
christian: approval‑mozilla‑aurora+
christian: approval‑mozilla‑beta+
Details | Diff | Splinter Review

Description User image Phil Ringnalda (:philor) 2011-11-08 00:51:35 PST
Looks like it's during the hour from 23:00 to 24:00, starting last night, and I'd guess continuing for a week, until

let expirableTime = - 8 * 24 * 60 * 60 * 1000;

goes back to making a time that's more than 7 days in the past even allowing for the daylight saving time change.

I pushed to mozilla-inbound, a few minutes too late to catch this instance so it won't get a chance to take effect until tomorrow night, but I see by and friends that it's already on Aurora, and so will be on Beta tomorrow, so even if that's the right thing to do we'll need a bug and flags to land it there.
Comment 1 User image Marco Bonardo [::mak] 2011-11-08 02:12:13 PST
Thank you, yes subtracting 8 days is not enough due to the fact expiration uses
strftime('%s','now','localtime','start of day','-7 days','utc')
that also subtracts today

expiration tests do different and that's saving them, not sure why I didn't fix that test the same way :(
Comment 2 User image Marco Bonardo [::mak] 2011-11-08 02:21:13 PST
Created attachment 572761 [details] [diff] [review]
patch v1.0
Comment 3 User image Marco Bonardo [::mak] 2011-11-08 02:30:45 PST
Comment on attachment 572761 [details] [diff] [review]
patch v1.0

Supposing this will land after the Aurora uplift, this should be fixed in Aurora and Beta too.

Comment 5 User image Marco Bonardo [::mak] 2011-11-09 05:25:00 PST
Comment 6 User image christian 2011-11-15 13:38:05 PST
Comment on attachment 572761 [details] [diff] [review]
patch v1.0

[triage comment]
Approved for beta and aurora. Please land as soon as possible.
Comment 7 User image christian 2011-11-15 17:21:20 PST
I landed this on aurora:

But it din't apply cleanly to beta. Please land on beta.
Comment 8 User image Marco Bonardo [::mak] 2011-11-16 09:30:24 PST
yeah for beta the 9 should be changed to a 8, since Aurora had a workaround philor pushed temporily in central the day before the merge.
Will do that.
Comment 9 User image Marco Bonardo [::mak] 2011-11-16 17:20:00 PST

Note You need to log in before you can comment on or make changes to this bug.