Windows power management messages shouldn't rely on hidden window

RESOLVED FIXED in mozilla11

Status

()

Core
Widget: Win32
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: Neil Deakin, Assigned: Neil Deakin)

Tracking

(Blocks: 1 bug)

Trunk
mozilla11
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 572793 [details] [diff] [review]
patch

Instead, use a global to store what messages have been sent.

As an aside, the documentation for WM_POWERBROADCAST says that several messages with different PBT_APMRESUME* values for wParam can be sent in sequence, which implies the existing code could send multiple notifications. Using a global also prevents this.

I'm using a virtual machine and am not sure how to test any of this.
Attachment #572793 - Flags: review?(jmathies)

Comment 1

6 years ago
Side note, I'm working on a stand alone service that listens for these and supports observer events and a simple callback mechanism for bug 679240. I plan to move the code for this out of widget. (There's win and mac code currently that can be moved.)

Updated

6 years ago
Attachment #572793 - Flags: review?(jmathies) → review+
https://hg.mozilla.org/mozilla-central/rev/53a4a92228f8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
(Assignee)

Updated

5 years ago
Blocks: 71895
You need to log in before you can comment on or make changes to this bug.