700654 - [layers] Different tabs don't have different visible areas

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

Open two tabs, zoom/pan in one of them. Then switch tabs, and note how the other one has also been zoom/panned. This should not be happening.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: (1/2) Some code cleanup

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: (2/2) Per-tab page size and visible area

Both of these patches are based on the code that landed on birch (48e52668c10a) and will need to be rebased on top of the newest patch queue before landing. I can take care of that if the patches are fundamentally ok.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 572814 [details] [diff] [review]
(1/2) Some code cleanup

Obsoleting this patch as I moved it into the birch-pan-zoom patch queue instead

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Attachment: Per-tab page size and visible area (v2)

Update patch to also hook into handleAddTab, since that can also select a new tab and needs to kick the layer client.

Comment 5

[Patrick Walton (:pcwalton)]

Comment on attachment 572999 [details] [diff] [review]
Per-tab page size and visible area (v2)

Review of attachment 572999 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with name changes.

::: embedding/android/Tab.java
@@ +76,5 @@
>      private boolean mBookmark;
>      private HashMap<String, DoorHanger> mDoorHangers;
>  
> +    private IntSize mPageSize;
> +    private IntRect mVisibleArea;

mVisibleRect maybe? I've tended to use that name.

@@ +322,5 @@
> +    IntSize getPageSize() {
> +        return mPageSize;
> +    }
> +
> +    IntRect getVisibleArea() {

I'd call this "getVisibleRect".

::: embedding/android/gfx/PlaceholderLayerClient.java
@@ -100,1 +103,5 @@
> >      public void setPageSize(IntSize pageSize) { mPageSize = pageSize; }
> > +
> > +    public void tabChanged(IntSize pageSize, IntRect visibleArea) {
> > +        // can never happen because gecko is required to change tabs, and
> > +        // the GeckoSoftwareLayerClient replaces this when gecko comes up

Maybe throw then?

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Attachment: Per-tab page size and visible area (v3)

Un-bitrotted such that it applies on top of a bunch of patches in the birch-pan-zoom queue (http://hg.mozilla.org/users/pwalton_mozilla.com/birch-pan-zoom/file/1deab2cd4eaf)

Comment 7

[Kartikaya Gupta (email:[e-mail])]

This patch has been rolled into Chris' correct-displayport patch in the patch queue.

Comment 9

[Kartikaya Gupta (email:[e-mail])]

This should be fixed as of https://hg.mozilla.org/projects/birch/rev/3f0f2ffed076

Comment 10

[Camelia Urian]

Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111127 Firefox/11.0a1 Fennec/11.0a1
Device: HTC Desire Z
OS: Android 2.3

Zoom/Pann is not applied to all opened tabs, only to the tab were you zoomed/panned.