The default bug view has changed. See this FAQ.

[layers] Different tabs don't have different visible areas

VERIFIED FIXED

Status

()

Firefox for Android
General
P1
normal
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: kats, Assigned: cwiiis)

Tracking

unspecified
All
Android
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Open two tabs, zoom/pan in one of them. Then switch tabs, and note how the other one has also been zoom/panned. This should not be happening.
Depends on: 695448
Created attachment 572814 [details] [diff] [review]
(1/2) Some code cleanup
Attachment #572814 - Flags: review?(pwalton)
Created attachment 572815 [details] [diff] [review]
(2/2) Per-tab page size and visible area

Both of these patches are based on the code that landed on birch (48e52668c10a) and will need to be rebased on top of the newest patch queue before landing. I can take care of that if the patches are fundamentally ok.
Attachment #572815 - Flags: review?
Attachment #572815 - Flags: review? → review?(pwalton)
Summary: [panzoom] Different tabs don't have different visible areas → [layers] Different tabs don't have different visible areas
Comment on attachment 572814 [details] [diff] [review]
(1/2) Some code cleanup

Obsoleting this patch as I moved it into the birch-pan-zoom patch queue instead
Attachment #572814 - Attachment is obsolete: true
Attachment #572814 - Flags: review?(pwalton)
Created attachment 572999 [details] [diff] [review]
Per-tab page size and visible area (v2)

Update patch to also hook into handleAddTab, since that can also select a new tab and needs to kick the layer client.
Attachment #572815 - Attachment is obsolete: true
Attachment #572815 - Flags: review?(pwalton)
Attachment #572999 - Flags: review?(pwalton)
Comment on attachment 572999 [details] [diff] [review]
Per-tab page size and visible area (v2)

Review of attachment 572999 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with name changes.

::: embedding/android/Tab.java
@@ +76,5 @@
>      private boolean mBookmark;
>      private HashMap<String, DoorHanger> mDoorHangers;
>  
> +    private IntSize mPageSize;
> +    private IntRect mVisibleArea;

mVisibleRect maybe? I've tended to use that name.

@@ +322,5 @@
> +    IntSize getPageSize() {
> +        return mPageSize;
> +    }
> +
> +    IntRect getVisibleArea() {

I'd call this "getVisibleRect".

::: embedding/android/gfx/PlaceholderLayerClient.java
@@ -100,1 +103,5 @@
> >      public void setPageSize(IntSize pageSize) { mPageSize = pageSize; }
> > +
> > +    public void tabChanged(IntSize pageSize, IntRect visibleArea) {
> > +        // can never happen because gecko is required to change tabs, and
> > +        // the GeckoSoftwareLayerClient replaces this when gecko comes up

Maybe throw then?
Attachment #572999 - Flags: review?(pwalton) → review+

Updated

5 years ago
Priority: -- → P1
Created attachment 573914 [details] [diff] [review]
Per-tab page size and visible area (v3)

Un-bitrotted such that it applies on top of a bunch of patches in the birch-pan-zoom queue (http://hg.mozilla.org/users/pwalton_mozilla.com/birch-pan-zoom/file/1deab2cd4eaf)
Attachment #572999 - Attachment is obsolete: true
Attachment #573914 - Flags: review+
This patch has been rolled into Chris' correct-displayport patch in the patch queue.
Assignee: kgupta → chrislord.net
Duplicate of this bug: 702950
This should be fixed as of https://hg.mozilla.org/projects/birch/rev/3f0f2ffed076
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 10

5 years ago
Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:11.0a1) Gecko/20111127 Firefox/11.0a1 Fennec/11.0a1
Device: HTC Desire Z
OS: Android 2.3

Zoom/Pann is not applied to all opened tabs, only to the tab were you zoomed/panned.
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.