700656 - Include peptests in packaged-tests

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Andrew Halberstadt [:ahal]]

Right now there aren't many peptests (just what I've written for example/testing purposes) but we should check them into m-c and make sure they are included in packaged tests so:

1) Developers can find them and possibly add their own tests
2) We can start running peptest on tinderbox

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Patch 1.0 - Package peptests

I think this was everything I needed to do. It works when I run make package-tests.

This only adds the tests to m-c and leaves the harness out. There is some discussion on bug 700415 about whether or not to commit the harness.

Comment 2

[Andrew Halberstadt [:ahal]]

So having the tests in packaged tests is the only(?) thing that we (ateam) need to do that is preventing aki from getting peptests running on tryserver.

I propose that we land the tests first so we can get them running on tryserver, and figure out how best to mirror the harness and land that later. In the mean time if I make a major change to the harness I can manually update the zip that the production mozharness configs are pointing to.

Comment 3

[cmtalbert]

Comment on attachment 572886 [details] [diff] [review]
Patch 1.0 - Package peptests

Review of attachment 572886 [details] [diff] [review]:
-----------------------------------------------------------------

These look good, I have the one nit below.

Also, because these will be used as the "how-to" of peptests, please include one that does not use a mozmill driver API so that people can see how to do that as well.

r+ with the extra test added.

::: testing/testsuite-targets.mk
@@ +13,5 @@
>  #
>  # The Original Code is Mozilla Test Harnesses
>  #
>  # The Initial Developer of the Original Code is
> +#   Mozilla Corporation

Don't change this.  It is correct as written.

Comment 4

[cmtalbert]

(In reply to Andrew Halberstadt [:ahal] from comment #2)
> So having the tests in packaged tests is the only(?) thing that we (ateam)
> need to do that is preventing aki from getting peptests running on tryserver.
> 
> I propose that we land the tests first so we can get them running on
> tryserver, and figure out how best to mirror the harness and land that
> later. In the mean time if I make a major change to the harness I can
> manually update the zip that the production mozharness configs are pointing
> to.
I agree with this as a first step approach.  Let's make this happen.

Comment 5

[Andrew Halberstadt [:ahal]]

Attachment: Patch 2.0 - Package peptests

Here's an updated patch with an additional test and fixes the license. It also adds licenses to all the tests.

I'll need someone to take care of committing the patch to m-c.

Aki: once this gets committed, the manifest you should use lives in the packaged-tests at "peptest/tests/firefox/firefox_all.ini"

Comment 6

[Andrew Halberstadt [:ahal]]

Attachment: Patch 2.1 - Package peptests

Realized I forgot to do some cleanup to the tests that I wanted to.

Comment 7

[cmtalbert]

Holy pushing before morning coffee batman.

Sorry mozilla-inbound sheriffs for the screwup this morning, but this has landed on m-i: https://hg.mozilla.org/integration/mozilla-inbound/rev/bb7db43ac63e

Comment 8

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/bb7db43ac63e

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 573902 [details] [diff] [review]
Patch 2.1 - Package peptests

>diff --git a/testing/peptest/Makefile.in b/testing/peptest/Makefile.in
>new file mode 100644
>--- /dev/null
>+++ b/testing/peptest/Makefile.in
>@@ -0,0 +1,56 @@
>+# ***** BEGIN LICENSE BLOCK *****
>+# Version: MPL 1.1/GPL 2.0/LGPL 2.1
>+#
>+# The contents of this file are subject to the Mozilla Public License Version
>+# 1.1 (the "License"); you may not use this file except in compliance with
>+# the License. You may obtain a copy of the License at
>+# http://www.mozilla.org/MPL/
>+#
>+# Software distributed under the License is distributed on an "AS IS" basis,
>+# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
>+# for the specific language governing rights and limitations under the
>+# License.
>+#
>+# The Original Code is peptest.
>+#
>+# The Initial Developer of the Original Code is
>+#   Mozilla Corporation 

That's wrong. See http://blog.gerv.net/2010/02/mpl_initial_developer_for_mozilla_employ/ and push a followup please.

Comment 10

[Andrew Halberstadt [:ahal]]

We'll be pushing some more test infrastructure soon, I'll fix it in that patch.