Closed
Bug 700734
Opened 9 years ago
Closed 9 years ago
Unnecessary "not derived from nsISupports" warnings for XPCOM pseudo-enums
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: Irving, Assigned: Irving)
Details
Attachments
(1 file)
1.56 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
Thunderbird has many IDL definitions of pseudo-enums, basically an IDL interface that only declares a bunch of constants. Because we never create an instance of the IDL object, it doesn't need any of the normal nsISupports infrastructure. xpcom prints warnings about all of these, like: warning: interface 'nsMsgPriority' not derived from nsISupports, /Users/ireid/tbird/comm-central/mailnews/base/public/MailNewsTypes2.idl line 52:0 interface nsMsgPriority { ^ Based on a conversation on irc #developers, this warning doesn't add much value and can be removed.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #572912 -
Flags: review?(khuey)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → irving
Attachment #572912 -
Flags: review?(khuey) → review+
Assignee | ||
Comment 2•9 years ago
|
||
I don't have mozilla-central checkin privileges; anyone ready to take this on?
Status: NEW → ASSIGNED
Keywords: checkin-needed
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8e7225a8b1cc
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•