Esc doesn't make iframe leave DOM fullscreen mode

VERIFIED FIXED in Firefox 10

Status

()

Core
DOM: Core & HTML
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Daniel, Assigned: cpearce)

Tracking

({verified-beta})

11 Branch
mozilla11
x86_64
Windows 7
verified-beta
Points:
---

Firefox Tracking Flags

(firefox8 unaffected, firefox9 unaffected, firefox10+ verified, firefox11 verified)

Details

(Whiteboard: [qa!], URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111102223350

Steps to reproduce:

Viewing an iframe in DOM full-screen mode pressing the escape key doesn't make it leave fullscreen. 

str
1. Open http://www.thecssninja.com/demo/fullscreen/
2. Click the "Fullscreen iframe" button
3. Click anywhere inside the iframe
4. Now pressing escape has no effect
(Reporter)

Updated

6 years ago

Updated

6 years ago
tracking-firefox10: --- → ?
(Assignee)

Comment 1

6 years ago
So the issue here is that if you focus a non-fullscreen frame the key events won't go through the full-screen document's presshell's event handler. We should ensure that ESC *always* exits full-screen, and so check if the root document is full-screen rather than if the focused document is in PresShell::HandleEventInternal().
Component: General → DOM: Core & HTML
QA Contact: general → general
(Assignee)

Updated

6 years ago
Blocks: 545812
(Assignee)

Comment 2

6 years ago
Created attachment 574195 [details] [diff] [review]
Patch

Instead of checking if a keyevent's target document is full-screen, check if the root document is full-screen, and exit if ESC is pressed. This means if ESC is pressed when a non-full-screen iframe which is contained inside a full-screen document is focused, you'll still exit full-screen.
Assignee: nobody → chris
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #574195 - Flags: review?(bugs)

Updated

6 years ago
Attachment #574195 - Flags: review?(bugs) → review+
(Assignee)

Comment 3

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/53ef2ac3a1fc

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/53ef2ac3a1fc
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
(Assignee)

Updated

6 years ago
status-firefox10: --- → affected
status-firefox11: --- → fixed
status-firefox8: --- → unaffected
status-firefox9: --- → unaffected
(Assignee)

Comment 5

6 years ago
Comment on attachment 574195 [details] [diff] [review]
Patch

Requesting approval for Aurora because this bug prevents the a simple way to avoid the "Press ESC to leave full-screen" warning when in full-screen mode. Without this we're vulnerable to phishing.
Attachment #574195 - Flags: approval-mozilla-aurora?

Updated

6 years ago
Attachment #574195 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 6

6 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/e70f5c9f61b1
status-firefox10: affected → fixed
Whiteboard: [qa+]
ESC key works fine now. This is verified fixed on Firefox 10 Beta2:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20100101 Firefox/10.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0) Gecko/20100101 Firefox/10.0
status-firefox10: fixed → verified
Whiteboard: [qa+] → [qa+][qa!:10]
Keywords: verified-beta

Updated

6 years ago
tracking-firefox10: ? → +
This is verified fixed on Firefox 11b1:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20100101 Firefox/11.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:11.0) Gecko/20100101 Firefox/11.0
Status: RESOLVED → VERIFIED
status-firefox11: fixed → verified
Whiteboard: [qa+][qa!:10] → [qa!]
You need to log in before you can comment on or make changes to this bug.