700889 - Frontend needs strategy to deal with non-200 responses

Status: RESOLVED FIXED

(Pancake Graveyard :: Front-end, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1. go to https://pancake.mozillalabs.com/addon/push
2. hit cancel
3. go back to pancake

Expected: no web page stored
Actual : new page for 401 (if you had wiped you would see it)

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Moving this to the iOS module since this is something that we can probably detect on the native side after loading a page.

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Assigning this back to frontend now that the two native bugs that this depends on have been resolved. See https://bugzilla.mozilla.org/show_bug.cgi?id=732425 and https://bugzilla.mozilla.org/show_bug.cgi?id=751189

Comment 3

[Sam Foster [:sfoster] (he/him)]

Fixed in: https://bitbucket.org/mozillapancake/pancake/changeset/40dd6145e09f

I've added 'status' as an attribute on the SiteModel we use to represent these links in the drawer, and a dynamic className in the view so it gets a class status--{ok|error} which we can style as necessary. Right now it just makes the link text italic. 

So the strategy is to treat non-200 responses as valid pages and go ahead and render them in the stack, but to mark them visibly as not-ok at last request - which I think is the right thing to do. 

Note this doesn't handle 3* requests explicitly: they will just be 'ok' currently. My understanding is that'll be done upstream so we shouldn't be seeing any 300-range response codes. 

For 400 and 500 statuses, the user may want to go back and try again later - I don't think we should presume to remove these automatically.