The default bug view has changed. See this FAQ.

Android GfxInfo attempts to use Build.HARDWARE field on SDK <8

RESOLVED FIXED in mozilla11

Status

()

Core
Widget: Android
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jdm, Assigned: jdm)

Tracking

Trunk
mozilla11
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
http://mxr.mozilla.org/mozilla-central/source/widget/src/android/GfxInfo.cpp#112 and http://mxr.mozilla.org/mozilla-central/source/widget/src/android/GfxInfo.cpp#192 cause exceptions to show up in my logcat output. They should be modeled after the code here: http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsSystemInfo.cpp#187
(Assignee)

Comment 1

5 years ago
Created attachment 573868 [details] [diff] [review]
Avoid using the HARDWARE field on Android SDK versions <8.
Attachment #573868 - Flags: review?(doug.turner)

Comment 2

5 years ago
Comment on attachment 573868 [details] [diff] [review]
Avoid using the HARDWARE field on Android SDK versions <8.

Review of attachment 573868 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/android/GfxInfo.cpp
@@ +108,5 @@
>        aAdapterDescription.Append(NS_LITERAL_STRING("', Manufacturer: '"));
>        if (mozilla::AndroidBridge::Bridge()->GetStaticStringField("android/os/Build", "MANUFACTURER", str))
>          aAdapterDescription.Append(str);
>        aAdapterDescription.Append(NS_LITERAL_STRING("', Hardware: '"));
> +      PRInt32 version;

add a comment that says something like 'HARDWARE isn't available on Android SDK < 8'
Attachment #573868 - Flags: review?(doug.turner) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/cf362eb76b16
Assignee: nobody → josh
https://hg.mozilla.org/mozilla-central/rev/cf362eb76b16
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.