Last Comment Bug 700931 - Android GfxInfo attempts to use Build.HARDWARE field on SDK <8
: Android GfxInfo attempts to use Build.HARDWARE field on SDK <8
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget: Android (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla11
Assigned To: Josh Matthews [:jdm]
:
: Jim Chen [:jchen] [:darchons]
Mentors:
Depends on:
Blocks: 619578 668004
  Show dependency treegraph
 
Reported: 2011-11-08 21:18 PST by Josh Matthews [:jdm]
Modified: 2011-11-25 02:25 PST (History)
2 users (show)
mounir: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Avoid using the HARDWARE field on Android SDK versions <8. (2.24 KB, patch)
2011-11-11 11:35 PST, Josh Matthews [:jdm]
doug.turner: review+
Details | Diff | Splinter Review

Comment 1 User image Josh Matthews [:jdm] 2011-11-11 11:35:38 PST
Created attachment 573868 [details] [diff] [review]
Avoid using the HARDWARE field on Android SDK versions <8.
Comment 2 User image Doug Turner (:dougt) 2011-11-11 12:16:10 PST
Comment on attachment 573868 [details] [diff] [review]
Avoid using the HARDWARE field on Android SDK versions <8.

Review of attachment 573868 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/android/GfxInfo.cpp
@@ +108,5 @@
>        aAdapterDescription.Append(NS_LITERAL_STRING("', Manufacturer: '"));
>        if (mozilla::AndroidBridge::Bridge()->GetStaticStringField("android/os/Build", "MANUFACTURER", str))
>          aAdapterDescription.Append(str);
>        aAdapterDescription.Append(NS_LITERAL_STRING("', Hardware: '"));
> +      PRInt32 version;

add a comment that says something like 'HARDWARE isn't available on Android SDK < 8'
Comment 4 User image Mounir Lamouri (:mounir) 2011-11-25 02:25:28 PST
https://hg.mozilla.org/mozilla-central/rev/cf362eb76b16

Note You need to log in before you can comment on or make changes to this bug.