700931 - Android GfxInfo attempts to use Build.HARDWARE field on SDK <8

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Josh Matthews [:jdm]]

http://mxr.mozilla.org/mozilla-central/source/widget/src/android/GfxInfo.cpp#112 and http://mxr.mozilla.org/mozilla-central/source/widget/src/android/GfxInfo.cpp#192 cause exceptions to show up in my logcat output. They should be modeled after the code here: http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsSystemInfo.cpp#187

Comment 1

[Josh Matthews [:jdm]]

Attachment: Avoid using the HARDWARE field on Android SDK versions <8.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 573868 [details] [diff] [review]
Avoid using the HARDWARE field on Android SDK versions <8.

Review of attachment 573868 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/src/android/GfxInfo.cpp
@@ +108,5 @@
>        aAdapterDescription.Append(NS_LITERAL_STRING("', Manufacturer: '"));
>        if (mozilla::AndroidBridge::Bridge()->GetStaticStringField("android/os/Build", "MANUFACTURER", str))
>          aAdapterDescription.Append(str);
>        aAdapterDescription.Append(NS_LITERAL_STRING("', Hardware: '"));
> +      PRInt32 version;

add a comment that says something like 'HARDWARE isn't available on Android SDK < 8'

Comment 3

[Josh Matthews [:jdm]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/cf362eb76b16

Comment 4

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/mozilla-central/rev/cf362eb76b16