Closed
Bug 700931
Opened 13 years ago
Closed 13 years ago
Android GfxInfo attempts to use Build.HARDWARE field on SDK <8
Categories
(Core Graveyard :: Widget: Android, defect)
Core Graveyard
Widget: Android
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla11
People
(Reporter: jdm, Assigned: jdm)
References
Details
Attachments
(1 file)
|
2.24 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
http://mxr.mozilla.org/mozilla-central/source/widget/src/android/GfxInfo.cpp#112 and http://mxr.mozilla.org/mozilla-central/source/widget/src/android/GfxInfo.cpp#192 cause exceptions to show up in my logcat output. They should be modeled after the code here: http://mxr.mozilla.org/mozilla-central/source/xpcom/base/nsSystemInfo.cpp#187
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #573868 -
Flags: review?(doug.turner)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 573868 [details] [diff] [review]
Avoid using the HARDWARE field on Android SDK versions <8.
Review of attachment 573868 [details] [diff] [review]:
-----------------------------------------------------------------
::: widget/src/android/GfxInfo.cpp
@@ +108,5 @@
> aAdapterDescription.Append(NS_LITERAL_STRING("', Manufacturer: '"));
> if (mozilla::AndroidBridge::Bridge()->GetStaticStringField("android/os/Build", "MANUFACTURER", str))
> aAdapterDescription.Append(str);
> aAdapterDescription.Append(NS_LITERAL_STRING("', Hardware: '"));
> + PRInt32 version;
add a comment that says something like 'HARDWARE isn't available on Android SDK < 8'
Attachment #573868 -
Flags: review?(doug.turner) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Assignee: nobody → josh
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Flags: in-testsuite-
OS: Mac OS X → All
Hardware: x86 → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•