Scaling of favicons should be either 1x or 2x, never inbetween

VERIFIED FIXED

Status

()

Firefox for Android
General
P3
normal
VERIFIED FIXED
6 years ago
10 months ago

People

(Reporter: limi, Assigned: sriram)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(1 attachment)

Created attachment 573085 [details]
Showing the blurred edges of favicon scaling

Right now, it looks like we scale up favicons and introduce blur/antialias by scaling them to sizes that aren't 1:1 or 2:1.

If the URL bar has enough space on a given device to render the favicon at 2x size, it should do that, otherwise it should render it at 1:1 and center it instead. Scaling 16x16 icons with antialias just looks bad.

(Of course, if there's a 32x32 icon and we have the space, we should use that)

Attached is a screenshot that shows the blurring introduced.
Hm, the favicons should be displaying at 32x32, and upscaled crisply if there's only a 16x16 available. 

The current nightlies seem to be drawing them at 36x36, so they need to come down a bit. And we need to make sure we're using crisp scaling, rather than anti-aliased.

Updated

6 years ago
Assignee: nobody → madhava
Can we see why we seem to be doing the 36x36? We should be 2x-ing them to 32px when necessary.
Assignee: madhava → nobody

Updated

6 years ago
Assignee: nobody → sriram
Priority: -- → P3
(Assignee)

Comment 3

6 years ago
The favicons are using 24x24 in the URL bar and tabs-tray. Since it is in "dip", they seem to be like 36X36 because of the device's dpi.
(Assignee)

Updated

6 years ago
Depends on: 700936
(Assignee)

Comment 4

6 years ago
Bug 700936 fixes the favicon in the URL bar. The rest of the favicons should be decided on a case by case basis.
fixed by bug 700936
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.