700937 - Scaling of favicons should be either 1x or 2x, never inbetween

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Alex Limi (:limi) — Firefox UX Team]

Attachment: Showing the blurred edges of favicon scaling

Right now, it looks like we scale up favicons and introduce blur/antialias by scaling them to sizes that aren't 1:1 or 2:1.

If the URL bar has enough space on a given device to render the favicon at 2x size, it should do that, otherwise it should render it at 1:1 and center it instead. Scaling 16x16 icons with antialias just looks bad.

(Of course, if there's a 32x32 icon and we have the space, we should use that)

Attached is a screenshot that shows the blurring introduced.

Comment 1

[Ian Barlow (:ibarlow)]

Hm, the favicons should be displaying at 32x32, and upscaled crisply if there's only a 16x16 available. 

The current nightlies seem to be drawing them at 36x36, so they need to come down a bit. And we need to make sure we're using crisp scaling, rather than anti-aliased.

Comment 2

[Madhava Enros [:madhava]]

Can we see why we seem to be doing the 36x36? We should be 2x-ing them to 32px when necessary.

Comment 3

[Sriram Ramasubramanian [:sriram]]

The favicons are using 24x24 in the URL bar and tabs-tray. Since it is in "dip", they seem to be like 36X36 because of the device's dpi.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Bug 700936 fixes the favicon in the URL bar. The rest of the favicons should be decided on a case by case basis.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

fixed by bug 700936