The default bug view has changed. See this FAQ.

Fix GCC compile warnings in XPConnect

RESOLVED FIXED in mozilla11

Status

()

Core
XPConnect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

(Blocks: 1 bug)

unspecified
mozilla11
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 573157 [details] [diff] [review]
patch

Compiling XPConnect with GCC 4.6 gives 100s of warnings.  This patch fixes all but one that's actually from xpcom/ds/nsCheapSets.h that I was reluctant to address.  The nsDOMQS.h change fixed most of them.
Attachment #573157 - Flags: review?(bobbyholley+bmo)
Comment on attachment 573157 [details] [diff] [review]
patch

I don't think the explanatory comments are necessary - please kill them. r=bholley with that.

I'm not actually an XPConnect peer though (yet). Flagging peterv for the rubber stamp.
Attachment #573157 - Flags: review?(peterv)
Attachment #573157 - Flags: review?(bobbyholley+bmo)
Attachment #573157 - Flags: review+
Yeah, randomly initializing stuff to shut up compilers is a fairly common pattern.
Blocks: 187528
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [build_warning]
(Assignee)

Comment 3

6 years ago
Created attachment 573693 [details] [diff] [review]
patch v2

New patch:

- Fixes a couple more warnings that only occur in optimized builds.

- Removes the comments, except the one in xpc_qsUnwrapThis();  I think it's unusual enough (the warnings happen only in functions that call it) to be worth keeping, though I'll remove if others disagree strongly.
Assignee: nobody → nnethercote
Attachment #573157 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #573157 - Flags: review?(peterv)
Attachment #573693 - Flags: review?(peterv)
(Assignee)

Comment 4

5 years ago
peterv, can you please review this?  It's a tiny patch and bholley thinks its fine.

Comment 5

5 years ago
Comment on attachment 573693 [details] [diff] [review]
patch v2

Stealing.
Attachment #573693 - Flags: review?(peterv) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d052a4d8f2b
https://hg.mozilla.org/mozilla-central/rev/5d052a4d8f2b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.