Created attachment 573157 [details] [diff] [review] patch Compiling XPConnect with GCC 4.6 gives 100s of warnings. This patch fixes all but one that's actually from xpcom/ds/nsCheapSets.h that I was reluctant to address. The nsDOMQS.h change fixed most of them.
Comment on attachment 573157 [details] [diff] [review] patch I don't think the explanatory comments are necessary - please kill them. r=bholley with that. I'm not actually an XPConnect peer though (yet). Flagging peterv for the rubber stamp.
Yeah, randomly initializing stuff to shut up compilers is a fairly common pattern.
OS: Linux → All
Hardware: x86_64 → All
Created attachment 573693 [details] [diff] [review] patch v2 New patch: - Fixes a couple more warnings that only occur in optimized builds. - Removes the comments, except the one in xpc_qsUnwrapThis(); I think it's unusual enough (the warnings happen only in functions that call it) to be worth keeping, though I'll remove if others disagree strongly.
peterv, can you please review this? It's a tiny patch and bholley thinks its fine.
Comment on attachment 573693 [details] [diff] [review] patch v2 Stealing.
Attachment #573693 - Flags: review?(peterv) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
You need to log in before you can comment on or make changes to this bug.