701103 - Launch updater.exe in session 0 instead of in the session of the (admin) user running the update

Status: RESOLVED INVALID

(Toolkit :: Application Update, defect)

Description

[Brian R. Bondy [:bbondy]]

Before bug 481815, and after, we ran updates as the administrator user who elevated the process.  In bug 481815 for limited account users though, we run updates in session 0 since there is no more elevation. 

This is a follow up task to bug 481815 for always using session 0 whether the account is limited user or administrator.  This makes for less edge cases to test for.

Comment 1

[Brian R. Bondy [:bbondy]]

Attachment: Updates always run as session 0, callback runs as the session ID specified

This simplifies the main logic code quite a bit from Bug 481815 Patch 2 - Main service logic. v4''. 

To answer your question in Bug 481815, it was done that way originally for 2 reasons:
1) To keep the GUI (since this task may land 1 version before Ehsan's)
2) To keep the logic as close as possible to how it worked before.

I do agree that keeping things more consistent is better with less edge cases though.

Note: I did this work before the NSPR cross platform patch so this will land before the NSPR patch lands.
I did this task's testing after I submitted the NSPR patch though so that's why I'm submitting it after.

Comment 2

[Brian R. Bondy [:bbondy]]

Attachment: Patch 23.5 - Updates always run as session 0, callback runs as the session ID specified. v1'.

Comment 3

[Brian R. Bondy [:bbondy]]

Merging this into a consolidated patch in bug 481815.

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 573550 [details] [diff] [review]
Patch 23.5 - Updates always run as session 0, callback runs as the session ID specified. v1'.

It is late... is this patch still necessary?

Comment 5

[Brian R. Bondy [:bbondy]]

Correct this is old and the code was at some point taken into bug 481815.