Move "About Mozilla" from properties to dtd

VERIFIED FIXED

Status

SeaMonkey
UI Design
VERIFIED FIXED
18 years ago
14 years ago

People

(Reporter: Peter ``jag'' Annema, Assigned: Peter ``jag'' Annema)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(7 attachments)

(Assignee)

Description

18 years ago
This means we can remove helpMenuCreate() from utilityOverlay.js, but it also
means changing the Mac code which now reads from that properties file to instead
get the label from the menuitem.

Attaching a few patches soon.
(Assignee)

Comment 1

18 years ago
Created attachment 26147 [details] [diff] [review]
[patch] This should make Mac use the menuitem's label.
(Assignee)

Comment 2

18 years ago
Note: the above patch is completely untested, I wouldn't mind some Mac help,
cc'ing saari.

Attaching patches for the XP part.

Note2: once those patches are applied, the first patch should be changed to also
do s/releaseName/aboutName/
(Assignee)

Comment 3

18 years ago
Created attachment 26150 [details] [diff] [review]
[patch] XP part + fixing mac/nsMenu.cpp
(Assignee)

Comment 4

18 years ago
Created attachment 26151 [details] [diff] [review]
[patch] Remove aboutStrName from brand.properties once above two patches are applied
(Assignee)

Comment 5

18 years ago
timeless noted that when releaseUrl was moved from brand.properties to
region.properties it was incorrectly changed from
<http://www.mozilla.org/releases/> to
<http://www.mozilla.org/projects/seamonkey/release-notes/>

I'll undo that change before checking in.

Comment 6

18 years ago
r=timeless given that assurance.
(Assignee)

Comment 7

18 years ago
So it seems like the first patch needs to #include "nsHTMLAtoms.h" to work and
the .mcp will probably need to be modified to add an include path directly to
the source dir (this is what other places / unix makefiles seem to do).

Currently it will put "About" in the Mac help menu, but with patch 2 applied and
changing "releaseName" to "aboutName" in patch 1 it should say "About Mozilla"
or "About Netscape 6".

"Should" being the operative word here. If someone could confirm this for me
I'll attach the new patch.
i had to make some (minor) changes to the patches, but after doing that, this
worked on mac. 
(Assignee)

Comment 9

18 years ago
Created attachment 26234 [details] [diff] [review]
[patch] update to attach_id=26147, make mac use menuitem value
(Assignee)

Comment 10

18 years ago
Created attachment 26235 [details] [diff] [review]
[patch] a second attempt at that...
(Assignee)

Comment 11

18 years ago
Created attachment 26241 [details] [diff] [review]
[patch] add/improve comments in nsMenu(Bar).cpp

Comment 12

18 years ago
looks good to me, r=saari
(Assignee)

Comment 14

18 years ago
Created attachment 26264 [details] [diff] [review]
[patch] merging all above patches into one to make life easier
(Assignee)

Comment 15

18 years ago
okay, checked in, marking fixed.
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
rubberstamp.
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.