Closed Bug 70112 Opened 24 years ago Closed 24 years ago

Move "About Mozilla" from properties to dtd

Categories

(SeaMonkey :: UI Design, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jag+mozbugs, Assigned: jag+mozbugs)

Details

Attachments

(7 files)

This means we can remove helpMenuCreate() from utilityOverlay.js, but it also means changing the Mac code which now reads from that properties file to instead get the label from the menuitem. Attaching a few patches soon.
Note: the above patch is completely untested, I wouldn't mind some Mac help, cc'ing saari. Attaching patches for the XP part. Note2: once those patches are applied, the first patch should be changed to also do s/releaseName/aboutName/
timeless noted that when releaseUrl was moved from brand.properties to region.properties it was incorrectly changed from <http://www.mozilla.org/releases/> to <http://www.mozilla.org/projects/seamonkey/release-notes/> I'll undo that change before checking in.
r=timeless given that assurance.
So it seems like the first patch needs to #include "nsHTMLAtoms.h" to work and the .mcp will probably need to be modified to add an include path directly to the source dir (this is what other places / unix makefiles seem to do). Currently it will put "About" in the Mac help menu, but with patch 2 applied and changing "releaseName" to "aboutName" in patch 1 it should say "About Mozilla" or "About Netscape 6". "Should" being the operative word here. If someone could confirm this for me I'll attach the new patch.
i had to make some (minor) changes to the patches, but after doing that, this worked on mac.
looks good to me, r=saari
okay, checked in, marking fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
rubberstamp.
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: