701188 - Suboptimal use of cache-space for partial cache-entries with content-encoding

Status: RESOLVED WONTFIX

(Core :: Networking: Cache, defect)

Description

[Bjarne (:bjarne)]

Bug #612135 disabled range-requests for partially cached entries with content-encoding in a way which IMO is suboptimal (and may open up for more subtle bugs).

The sub-optimality is because nsHttpChannel::CloseCacheEntry() may leave cached partial entries which will never be re-used, because nsHttpResponseHead::IsResumable() can return true while nsHttpChannel::CheckCache() may not reuse it if it's content-encoded.

Comment 1

[Honza Bambas (:mayhemer)]

I think this is as well as bug 613159 dependent on the real usage numbers.

Comment 2

[Bjarne (:bjarne)]

The fix is pretty simple: Modify nsHttpResponseHead::IsResumable() to also include a check for content-encoding. That way, nsHttpResponseHead::IsResumable() returns *our* view on whether the response is resumable or not, and not just the definition from the Rfc.