Closed Bug 701244 Opened 8 years ago Closed 8 years ago

"Assertion failure: 0,"

Categories

(Core :: JavaScript Engine, defect, critical)

x86
macOS
defect
Not set
critical

Tracking

()

VERIFIED FIXED
mozilla11
Tracking Status
firefox10 --- verified

People

(Reporter: gkw, Assigned: luke)

References

(Blocks 1 open bug)

Details

(4 keywords, Whiteboard: js-triage-done [qa!])

Attachments

(2 files, 1 obsolete file)

Attached file stack
String(
    (function() {
        function k({
            d: {
                length
            }
        }) {}
    }), "\
    (function() {\
        function k({\
            d: {\
                length\
            }\
        }) {}\
    })\
")

asserts js debug shell on m-c changeset 4fb61ebbf8ff with patch v1 from bug 697279 without any CLI arguments at Assertion failure: 0,

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   79903:a6c390aa3bf2
user:        Luke Wagner
date:        Mon Nov 07 11:46:25 2011 -0800
summary:     Bug 696813 - Simplify Decompile (r=waldo)
Attached patch fix (obsolete) — Splinter Review
Mmm destructuring.
Assignee: general → luke
Status: NEW → ASSIGNED
Attachment #573384 - Flags: review?(jwalden+bmo)
Attached patch fixSplinter Review
Oops, patch should not include nsJSEnvironment hackery...
Attachment #573384 - Attachment is obsolete: true
Attachment #573384 - Flags: review?(jwalden+bmo)
Attachment #573396 - Flags: review?(jwalden+bmo)
Whiteboard: js-triage-needed → js-triage-done
Attachment #573396 - Flags: review?(jwalden+bmo) → review+
Comment on attachment 573396 [details] [diff] [review]
fix

Low-risk fix (backing out overzealous removal).
Attachment #573396 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/b7d2f71b4c87
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Attachment #573396 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: js-triage-done → js-triage-done [qa+]
OS; Mac OS X 10.6

I used the beta source with the latest revision (mozilla-beta-226c1a05e0b6) and built the js debug shell; then I run the test from comment #0 (./js testcaseFile) and no message was displayed. 
Is this what was needed to verify this issue?
Thanks!
(In reply to Mihaela Velimiroviciu [QA] from comment #7)
 
> Is this what was needed to verify this issue?

Yes that sounds alright. In general if you are not sure if you're testing correctly, try building the debug shell in both the most current and unfixed revisions to see the assertion going away :)
Setting VERIFIED based on previous comment. Thank you!
Status: RESOLVED → VERIFIED
Keywords: verified-beta
Whiteboard: js-triage-done [qa+] → js-triage-done [qa!]
A testcase for this bug was automatically identified at js/src/jit-test/tests/basic/testBug701244.js.
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.