JavaScript Error: "browser is null" {file: "chrome://browser/content/browser.js" line: 1091}

VERIFIED FIXED

Status

()

Firefox for Android
General
P2
normal
VERIFIED FIXED
6 years ago
3 years ago

People

(Reporter: wesj, Assigned: mfinkle)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(firefox11 fixed, fennec11+)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
This may be a dup?

I'm seeing this on pages with iframes. Presumably we're getting some web progress event from them, trying to get the associated browser and then use it. We could probably just see we have no browser and back off. We don't want to send progress events from iframes to java anyway... do we? Maybe on sites like gmail we want to show a spinner while the iframe loads?
(Reporter)

Comment 1

6 years ago
Created attachment 573378 [details]
Testpage

This is just a page with an iframe to reproduce the error on.

Updated

6 years ago
Assignee: nobody → mark.finkle
Priority: -- → P2
This was happening in the DOMContentLoaded event handler. We looked for the <browser> associated with the event.target (HTMLDocument) but didn't find one. Then we try to set focus to the null browser.
Created attachment 573833 [details] [diff] [review]
patch

No errors using the test page anymore. I stopped trying to focus the browser too. We don't need it. The keyboard comes up fine on Google and Bugzilla without forcing focus.
Attachment #573833 - Flags: review?(wjohnston)
Created attachment 573896 [details] [diff] [review]
patch 2

adds more checks
Attachment #573833 - Attachment is obsolete: true
Attachment #573833 - Flags: review?(wjohnston)
Attachment #573896 - Flags: review?(wjohnston)
(Reporter)

Updated

6 years ago
Attachment #573896 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/projects/birch/rev/9c6438dd5534
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 6

6 years ago
I loaded the test page and I looked in aLogcat, there was no JavaScript Error. Marking this as verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:11.0a1) Gecko/20111123 Firefox/11.0a1 Fennec/11.0a1
Device: LG Optimus 2X (Android 2.2)
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
status-firefox11: --- → fixed
You need to log in before you can comment on or make changes to this bug.