Closed Bug 701245 Opened 8 years ago Closed 8 years ago

JavaScript Error: "browser is null" {file: "chrome://browser/content/browser.js" line: 1091}

Categories

(Firefox for Android :: General, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox11 --- fixed
fennec 11+ ---

People

(Reporter: wesj, Assigned: mfinkle)

Details

Attachments

(2 files, 1 obsolete file)

This may be a dup?

I'm seeing this on pages with iframes. Presumably we're getting some web progress event from them, trying to get the associated browser and then use it. We could probably just see we have no browser and back off. We don't want to send progress events from iframes to java anyway... do we? Maybe on sites like gmail we want to show a spinner while the iframe loads?
Attached file Testpage
This is just a page with an iframe to reproduce the error on.
Assignee: nobody → mark.finkle
Priority: -- → P2
This was happening in the DOMContentLoaded event handler. We looked for the <browser> associated with the event.target (HTMLDocument) but didn't find one. Then we try to set focus to the null browser.
Attached patch patch (obsolete) — Splinter Review
No errors using the test page anymore. I stopped trying to focus the browser too. We don't need it. The keyboard comes up fine on Google and Bugzilla without forcing focus.
Attachment #573833 - Flags: review?(wjohnston)
Attached patch patch 2Splinter Review
adds more checks
Attachment #573833 - Attachment is obsolete: true
Attachment #573833 - Flags: review?(wjohnston)
Attachment #573896 - Flags: review?(wjohnston)
Attachment #573896 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/projects/birch/rev/9c6438dd5534
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
I loaded the test page and I looked in aLogcat, there was no JavaScript Error. Marking this as verified fixed on build: Mozilla /5.0 (Android;Linux armv7l;rv:11.0a1) Gecko/20111123 Firefox/11.0a1 Fennec/11.0a1
Device: LG Optimus 2X (Android 2.2)
Status: RESOLVED → VERIFIED
tracking-fennec: --- → 11+
You need to log in before you can comment on or make changes to this bug.